Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PublicRooms] Bug: Incorrect Docstring for Edit Name #3

Closed
EternalllZM opened this issue Feb 22, 2021 · 1 comment
Closed

[PublicRooms] Bug: Incorrect Docstring for Edit Name #3

EternalllZM opened this issue Feb 22, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@EternalllZM
Copy link

When first creating a PublicRoom system, the following will display for the name:
For the channel_name_template, enter a string, with {num} contained if you want it to be replaced with the number of active VCs.

However, when editing the name of the system, you will be met with the following:
Enter a string, with {creator} contained if you want it to be replaced with the VC creator's display name.

{creator} does not work with PublicRooms. However, it does work with PrivateRooms. The best solution in this case would be to make both options work on both systems. As both can identify the invoker of the channel creation.

@Obi-Wan3
Copy link
Owner

Thanks for reporting this! I think I just forgot to replace a docstring, as PrivateRooms was created first and quite a bit of code was reused between them. For making the {creator} option work on both of them, I don't think I will be adding that as I don't think the point of PublicRooms reflects having a room creator's name in the channel. However, I will definitely be fixing that docstring to have the correct instructions (that should be pushed in a few minutes, at which point I will also close this issue).

@Obi-Wan3 Obi-Wan3 self-assigned this Feb 22, 2021
@Obi-Wan3 Obi-Wan3 added the bug Something isn't working label Feb 22, 2021
@Obi-Wan3 Obi-Wan3 changed the title PublicRooms Displays Incorrect Information when Editing Name [PublicRooms] Bug: Incorrect Docstring for Edit Name Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants