Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge50: dotnet #1654

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Challenge50: dotnet #1654

merged 10 commits into from
Oct 7, 2024

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Oct 6, 2024

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

This PR adds challenge50

Relations

Closes #1243

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen requested a review from bendehaan as a code owner October 6, 2024 03:05
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe make the Version in the script a parameter?

.github/scripts/docker-create.sh Outdated Show resolved Hide resolved
@commjoen commjoen merged commit 0133bfd into master Oct 7, 2024
15 checks passed
@commjoen commjoen deleted the web-dotnetchallenge branch October 7, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a .net dll based RE challenge!
2 participants