add support for packaging

[diamant3]

Checklist

• I have followed the Contributor Guidelines.
• The code has been thoroughly tested in my local development environment with flake8 and pylint.
• The code is Python 3 compatible.
• The code follows the PEP8 styling guidelines with 4 spaces indentation.
• This Pull Request relates to only one issue or only one feature
• I have referenced the corresponding issue number in my commit message
• I have added the relevant documentation.
• My branch is up-to-date with the Upstream master branch.

Changes proposed in this pull request

for issue #633

Your development environment

• OS: Ubuntu(WSL)
• OS Version: 22.04
• Python Version: 3.10.12

[arkid15r]

Just a friendly unsolicited review.

I believe there is another pending PR aiming to resolve the issue (just FYI)

[arkid15r]

I'm not that familiar w/ poetry to make any strong suggestions here. However, this file doesn't look right from DRY perspective. Essentially, you have pretty much the same contents for both [project] and [tool.poetry] sections. Is there a way to avoid that?

[securestep9]

Poetry is a relatively new and clean package manager for Python which comes with several advantages over pip and it is using pyproject.toml - my problem with accepting both PRs is that they are not properly tested and perhaps submitted without proper understanding of the Poetry concepts and avoiding repetition - thanks for your review and pointing our the DRY principle.

https://blogs.sap.com/2022/05/08/why-you-should-use-poetry-instead-of-pip-or-conda-for-python-projects/

[arkid15r]

my problem with accepting both PRs is that they are not properly tested and perhaps submitted without proper understanding of the Poetry concepts and avoiding repetition

I see what you're saying. I may be able to look into consolidating and testing these PRs code to resolve your concerns this/next week.

// thanks for the link!

[arkid15r]

It doesn't look like an optional dependency to me.

[arkid15r]

It deserves the security topic:

Suggested change

	"Development Status :: 5 - Production/Stable",
	"Development Status :: 5 - Production/Stable",
	"Topic :: Security",

You can find more here -- https://pypi.org/pypi?%3Aaction=list_classifiers

[diamant3]

Thank you very much for the review! I'm sorry I overlooked that PR. I will just wait for the response from that PR before making any further changes on my side

[arkid15r]

No longer relevant, the workflow has been implemented in bdf281c