Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Clickjacking_Defense_Cheat_Sheet.md to address Double Clickjacking #1577

Open
kwwall opened this issue Jan 5, 2025 · 5 comments · May be fixed by #1609
Open

Update: Clickjacking_Defense_Cheat_Sheet.md to address Double Clickjacking #1577

kwwall opened this issue Jan 5, 2025 · 5 comments · May be fixed by #1609
Assignees
Labels
ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet.

Comments

@kwwall
Copy link
Collaborator

kwwall commented Jan 5, 2025

What is missing or needs to be updated?

The Clickjacking_Defense_Cheat_Sheet.md cheat sheet does not account for defenses from the new related attack dubbed "Double Clickjacking".

How should this be resolved?

At a minimum, we need to update this to mention that some of the defenses mentioned in the current CS are not effective. (Paulos Yibelo's blog post did not explictly mention whether frame-busting script was still effective, but it did note that relying only header defenses such as CSP frame-ancestors directory or X-Frame-Options or the "SameSite" cookie attribute were not effective.)

Other

Note: Do not ask me to submit a PR to address this issue as my depth of JavaScript is not sufficient for that. I only know enough to be effective at secure code reviews in regards to that.

@kwwall kwwall added ACK_WAITING Issue waiting acknowledgement from core team before to start the work to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet. HELP_WANTED Issue for which help is wanted to do the job. labels Jan 5, 2025
@kwwall kwwall changed the title Update: Clickjacking_Defense_Cheat_Sheet.md Update: Clickjacking_Defense_Cheat_Sheet.md to address Double Clickjacking Jan 6, 2025
@mackowski
Copy link
Collaborator

Thanks @kwwall! This is a good issue

@mackowski mackowski added ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. and removed ACK_WAITING Issue waiting acknowledgement from core team before to start the work to fix it. labels Jan 7, 2025
@yashgoyal0110
Copy link

anyone still workig on it?

@mackowski
Copy link
Collaborator

@yashgoyal0110 no-one is working on this currently. Do you want to help?

@caffeine-rohit
Copy link
Contributor

This is a critical security issue that needs to be addressed. I understand how Double Clickjacking works and why CSP, X-Frame-Options, and SameSite cookies are insufficient to fight with it . Fixing this requires strengthening client-side defenses with JavaScript and enhancing server-side security with improved headers and frame-busting mechanisms.
Let me know if I can proceed with the fix.
@mackowski @kwwall @szh

@kwwall
Copy link
Collaborator Author

kwwall commented Feb 1, 2025

@caffeine-rohit - Go for it. Please see the more detailed response I left you on OWASP Slack.

@mackowski mackowski removed the HELP_WANTED Issue for which help is wanted to do the job. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet.
Projects
None yet
4 participants