Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 2.1.12 with a more sensible modification to resolve #1265 #1710

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Sep 7, 2023

This Pull Request relates to issue #1265

@tghosth tghosth linked an issue Sep 7, 2023 that may be closed by this pull request
@elarlang
Copy link
Collaborator

elarlang commented Sep 7, 2023

see #1265 (comment)

@tghosth
Copy link
Collaborator Author

tghosth commented Sep 7, 2023

Changed as requested @elarlang

Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CWE-549 suits better: CWE-549 Missing Password Field Masking

@tghosth
Copy link
Collaborator Author

tghosth commented Sep 7, 2023

Nice! I did not know there was a CWE like that!

@tghosth tghosth requested a review from elarlang September 7, 2023 11:39
@elarlang elarlang merged commit 623fe1a into master Sep 7, 2023
2 checks passed
@tghosth tghosth deleted the 1265-requirement-of-masking-password branch September 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement of masking password
2 participants