Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 8.2.2 to resolve #1141 #1321

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Jul 26, 2022

This Pull Request relates to issue #1141

@elarlang
Copy link
Collaborator

my comment in issue: #1141 (comment)

Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session identifiers > session tokens

@tghosth
Copy link
Collaborator Author

tghosth commented Oct 23, 2022

@elarlang you think we should be saying session tokens instead of session identifiers?

@elarlang
Copy link
Collaborator

@elarlang you think we should be saying session tokens instead of session identifiers?

yes, as rest of the ASVS call it "session token" everywhere (3.4.1, 3.4.2, 3.4.3, 3.4.4, 3.4.5, 3.4.6, 3.5.2, 3.5.3, 7.1.1, 7.2.1, 8.2.3)

@tghosth
Copy link
Collaborator Author

tghosth commented Oct 27, 2022

Fair point @elarlang, is that ok now? :)

@elarlang elarlang merged commit 23cbc31 into master Oct 28, 2022
@tghosth tghosth deleted the 1141-questions-on-rigidity-of-token-based-session-storage-sessionstorage-for-token-based-sessions-guidance-in-822 branch October 28, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6) PR awaiting review _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
3 participants