Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.2-2.1.10 cites CWE-263 without warning about direct opposition #871

Closed
stiiin opened this issue Nov 8, 2020 · 4 comments
Closed

v4.0.2-2.1.10 cites CWE-263 without warning about direct opposition #871

stiiin opened this issue Nov 8, 2020 · 4 comments
Assignees

Comments

@stiiin
Copy link

stiiin commented Nov 8, 2020

Requirement 2.1.10 states:

Verify that there are no periodic credential rotation or password history requirements.

I will focus on the "credential rotation" part of this requirement; splitting this requirement is already discussed in #683.

The table refers to CWE-263 and NIST SP800-63B section 5.1.1.2 ("Memorized Secret Verifiers"). The NIST document mentions a similar requirement. However, that definition (as well as CWE-262) is in direct opposition to the ASVS requirement. Its extended description is as follows:

Just as neglecting to include functionality for the management of password aging is dangerous, so is allowing password aging to continue unchecked. Passwords must be given a maximum life span, after which a user is required to update with a new and different password.

Without any further warning to the contrary, I expect that a citation next to a requirement will refer to something that supports that requirement, or is at least compatible with it. I couldn't find anything to that effect in any text near the table, or any text that precedes it. So at the very least, I would expect some overall warning that some references may disagree with an ASVS' requirement.

This would still burden a reader with cross-referencing every requirement if the mapping with the cited publications is important to them (especially the NIST sections). Right now, I have no idea how many of these references are supporting or dissenting, let alone which. As such, it would be even better to have some sort of mark or footnote in the ASVS that points out which requirements are incompatible with the cited material.

For sake of transparency, I would not remove the reference.

@jmanico
Copy link
Member

jmanico commented Mar 12, 2021

Would you lie to give us a PR to this effect? I agree.

@elarlang
Copy link
Collaborator

I opened now this separate issue (#940 ) for splitting mentioned requirement and pointed out this CWE mismatch problem there as well. But I proposed to remove link to incorrect CWE which against vision here ("For sake of transparency, I would not remove the reference.")

@elarlang
Copy link
Collaborator

elarlang commented Apr 1, 2021

As I removed those mentioned CWE's with related issue #940 via PR #958, then this issue is not valid anymore.

@stiiin - if you think, that those references for incorrect CWE's are somehow needed, then please comment for reopen this issue.

@jmanico
Copy link
Member

jmanico commented Apr 1, 2021

Since this is resolved I'm closing for now, please reopen if needed.

@jmanico jmanico closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants