Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.2 - Multiple Concurrent Sessions Handling (Documentation) #2101

Closed
ryarmst opened this issue Sep 21, 2024 · 15 comments
Closed

1.3.2 - Multiple Concurrent Sessions Handling (Documentation) #2101

ryarmst opened this issue Sep 21, 2024 · 15 comments
Assignees
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet 4) proposal for review Issue contains clear proposal for add/change something V1 V3 _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@ryarmst
Copy link
Collaborator

ryarmst commented Sep 21, 2024

Starting with the following proposal for documenting the handling of multiple concurrent sessions:

# Description L1 L2 L3
1.3.2 Verify documentation of intended behavior and handling of multiple concurrent (parallel) sessions initiated for the same account or identity including all controls intended to terminate one or multiple active sessions.

L1 requirement based on 3.8.2, 3.8.5, and 3.8.6.

@jmanico
Copy link
Member

jmanico commented Sep 23, 2024

Like it! Thank you!

@tghosth tghosth added 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet _5.0 - prep This needs to be addressed to prepare 5.0 labels Sep 23, 2024
@tghosth
Copy link
Collaborator

tghosth commented Sep 23, 2024

Slight change

# Description L1 L2 L3
1.3.2 Verify that the application documents the intended behavior and handling of multiple concurrent (parallel) sessions initiated for the same account or identity including all controls intended to terminate one or multiple active sessions.

Overall I think it sounds good :)

@elarlang
Copy link
Collaborator

Verify that the application documents ...

this does not feel right :)

@ryarmst
Copy link
Collaborator Author

ryarmst commented Oct 13, 2024

How about:

# Description L1 L2 L3
1.3.2 Verify that the application documentation defines the intended behavior and handling of multiple concurrent (parallel) sessions initiated for the same account or identity including all controls intended to terminate one or multiple active sessions.

@elarlang
Copy link
Collaborator

I'm a bit worried, that "behavior and handling sessions" are a bit vague here. It's not clear from the requirement, what we need to verify and what must be done.

@ryarmst
Copy link
Collaborator Author

ryarmst commented Oct 14, 2024

Yes, on looking over, I agree. Consider:

# Description L1 L2 L3
1.3.2 Verify that the application documentation defines whether multiple concurrent (parallel) sessions initiated for the same account or identity are permitted and the controls (both administrative and user-facing) to identify and manage distinct active sessions.

This wording may exclude some possible desirable controls. Thoughts?

@elarlang
Copy link
Collaborator

Seems like a 2 separate topics here?

One requirement:

Verify that the documentation defines how many concurrent (parallel) sessions are allowed for one account.

And something for other - but what goal it has?

... and the controls (both administrative and user-facing) to identify and manage distinct active sessions.

@jmanico
Copy link
Member

jmanico commented Oct 15, 2024

Most every app I use allows for parallel sessions - which are secured by all of the other requirements we talk about in this section. I suggest we drop 1.3.2, it does not really help for security. Multiple sessions are the norm, I do not see why we need special requirements to talk about them.

@elarlang
Copy link
Collaborator

For example, if you have an backoffice account meant to be used from by one user from one workstation, you have logical limitation for "1 active session per account".

It depends on the application needs, that's why we need the documented security decision.

@jmanico
Copy link
Member

jmanico commented Oct 15, 2024

@elarlang This is such an edge case in my world - but I see it's more frequent in back-office and finance so I drop my concern.

@ryarmst
Copy link
Collaborator Author

ryarmst commented Oct 16, 2024

Following discussion with @elarlang, I will propose the following simplification for this requirement:

# Description L1 L2 L3
1.3.2 Verify that the application documentation defines whether multiple concurrent (parallel) sessions initiated for the same account or identity are permitted.

@elarlang
Copy link
Collaborator

Last proposal:

Verify that the application documentation defines whether multiple concurrent (parallel) sessions initiated for the same account or identity are permitted.

It defines it as boolean - multiple allowed or not, but does not set the limit, how many parallel sessions are allowed.

I prefer my direction:

Verify that the documentation defines how many concurrent (parallel) sessions are allowed for one account.

Just an idea - should it cover also the situation, when a "max amount of allowed sessions is reached" and then new authentication is made, is it FIFO there or anything else.

@ryarmst
Copy link
Collaborator Author

ryarmst commented Oct 21, 2024

How about this:

# Description L1 L2 L3
1.3.2 Verify that the documentation defines how many concurrent (parallel) sessions are allowed for one account as well as the intended behaviours and actions to be taken when the maximum number of active sessions is reached.

@elarlang
Copy link
Collaborator

Clear for me

@elarlang elarlang added the 4) proposal for review Issue contains clear proposal for add/change something label Oct 21, 2024
ryarmst added a commit to ryarmst/ASVS that referenced this issue Oct 21, 2024
@ryarmst
Copy link
Collaborator Author

ryarmst commented Oct 21, 2024

PR via #2171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet 4) proposal for review Issue contains clear proposal for add/change something V1 V3 _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

No branches or pull requests

4 participants