Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .compute() in convert_to_color #173

Open
leewujung opened this issue Aug 18, 2024 · 0 comments
Open

Remove .compute() in convert_to_color #173

leewujung opened this issue Aug 18, 2024 · 0 comments

Comments

@leewujung
Copy link
Member

For whatever reason .compute() is currently used at the end of convert_to_color to get the Sv data loaded into memory. This assumes that the dataset is loaded as a dask array, rather than a numpy array (which would actually results the plotting to error out, since .compute() does not exist for numpy arrays.

Removing .compute() works for when we load a xr.Dataset with chunks=None so that the content are numpy arrays. Need to test if without .compute() the function would still work normally.

The bigger picture though, behind this issue, is to review the current handling of input types (and chunking schemes?) in Echoshader, and see how that jives with performance when the data is large or small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant