From be04921820e74efdfd9700250089b9810d7baca5 Mon Sep 17 00:00:00 2001 From: Emilio Mayorga Date: Thu, 20 Jul 2023 14:31:28 -0700 Subject: [PATCH 1/2] docs: remove outdated Attention box in Data Processing page --- docs/source/process.rst | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/docs/source/process.rst b/docs/source/process.rst index f2baccbc4..527579e27 100644 --- a/docs/source/process.rst +++ b/docs/source/process.rst @@ -22,17 +22,7 @@ Functionality - EK80 and EA640 broadband echosounders: - Calibration based on pulse compression output in the - form of average over frequency (alpha). - - .. attention:: - This feature is still under development. - We found inconsistencies among pulse compression outputs - from EchoView, Matlab Echolab, and the echopype implementation, see - `#308 `_. - In addition, currently there are issues with calibrating files containing both - broadband and narrowband (the "CW mode") data, see - `#310 `_. - + form of average over frequency. - The same noise removal and MVBS computation functionality available to the narrowband echosounders. From 6b578e8a1ee3b09819b9521a79d3971e3154256b Mon Sep 17 00:00:00 2001 From: Emilio Mayorga Date: Wed, 26 Jul 2023 13:11:47 -0700 Subject: [PATCH 2/2] Add 3 non-convention variables to EK80 Beam groups; add missing long_name attr to slope var --- echopype/convert/set_groups_ek80.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/echopype/convert/set_groups_ek80.py b/echopype/convert/set_groups_ek80.py index 97d53383e..fc71846b5 100644 --- a/echopype/convert/set_groups_ek80.py +++ b/echopype/convert/set_groups_ek80.py @@ -901,6 +901,30 @@ def _assemble_ds_common(self, ch, range_sample_size): "slope": ( ["ping_time"], self.parser_obj.ping_data_dict["slope"][ch], + {"long_name": "Hann window slope parameter for transmit signal"}, + ), + "channel_mode": ( + ["ping_time"], + np.array(self.parser_obj.ping_data_dict["channel_mode"][ch], dtype=np.byte), + { + "long_name": "Transceiver mode", + "flag_values": [0, 1], + "flag_meanings": ["Active", "Inactive"], + }, + ), + "pulse_form": ( + ["ping_time"], + np.array(self.parser_obj.ping_data_dict["pulse_form"][ch], dtype=np.byte), + { + "long_name": "Pulse type", + "flag_values": [0, 1, 5], + "flag_meanings": ["CW", "FM", "FMD"], + }, + ), + "range_sample_offset": ( + ["ping_time"], + np.array(self.parser_obj.ping_data_dict["offset"][ch], dtype=int), + {"long_name": "First sample number"}, ), }, coords={