Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling of CW-based beamwidth parameters inverted #997

Closed
leewujung opened this issue Mar 20, 2023 · 1 comment
Closed

Scaling of CW-based beamwidth parameters inverted #997

leewujung opened this issue Mar 20, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@leewujung
Copy link
Member

leewujung commented Mar 20, 2023

In v0.6.4, the functionality to calibrate broadband Sv was overhauled. However, I just discovered one bug: the scaling of beamwidth parameters (beam_width_alongship and beam_width_athwartship) based on the center frequency of each ping wrt the nominal frequency of a given channel is inverted.

In the current (wrong) implementation, the higher the center frequency, the larger the beamwidth -- this is the opposite of what should happen.

I will create a patch to fix this ASAP and issue a v0.6.4.2 patch. However this means that the current tests against pyEcholab values are no longer valid. I will look into testing against Echoview values (while developing v0.6.4 I opted for testing against pyEcholab for band-averaged Sv). Turns out for that particular file used in test_calibrate_ek80.py, there was no need to scale CW-based cal parameters (stored in the Sonar/Beam_groupX group) because those cal parameters happen to exist in a frequency-dependent form (stored in the Vendor-specific group) for the BB channels. (To elaborate: scaling is only needed if a particular parameter is not available in the frequency-dependent form and needs to be estimated from CW-based values.)

I also noted this in an issue in pyEcholab here: CI-CMG/pyEcholab#66.

@leewujung leewujung added the bug Something isn't working label Mar 20, 2023
@leewujung leewujung added this to the 0.6.4.2 milestone Mar 20, 2023
@leewujung leewujung self-assigned this Mar 20, 2023
@github-project-automation github-project-automation bot moved this to Todo in Echopype Mar 20, 2023
@leewujung leewujung changed the title Beamwidth scaling inverted Scaling of CW-based beamwidth parameters inverted Mar 20, 2023
@leewujung leewujung moved this from Todo to In Progress in Echopype Mar 20, 2023
@leewujung leewujung modified the milestones: 0.6.4.2, 0.7.0 Mar 21, 2023
@leewujung
Copy link
Member Author

This is addressed in #998.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Echopype Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant