Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing coordinate attributes to MVBS dataset from compute_MVBS #481

Closed
Tracked by #591
emiliom opened this issue Nov 6, 2021 · 1 comment
Closed
Tracked by #591

Add missing coordinate attributes to MVBS dataset from compute_MVBS #481

emiliom opened this issue Nov 6, 2021 · 1 comment
Labels
enhancement This makes echopype better
Milestone
0.6.0

Comments

@emiliom
Copy link
Collaborator

emiliom commented Nov 6, 2021

In the MVBS xarray dataset produced by preprocess.compute_MVBS, ping_time and range are missing user-facing attributes (I think ping_time must have proper time encoding attributes). For example, see https://osoceanacoustics.github.io/echopype-examples/echopype_tour.html. I don't know if they're missing in the output of compute_Sv as well.
@emiliom emiliom changed the title Add missing coordinate attributes to MVBS Add missing coordinate attributes to MVBS dataset from compute_MVBS Nov 6, 2021
@emiliom emiliom added this to the 0.6.0 milestone Nov 7, 2021
@leewujung leewujung moved this to Todo in Echopype Nov 28, 2021
@leewujung leewujung moved this from Todo to In Progress in Echopype Jan 20, 2022
@leewujung leewujung added the enhancement This makes echopype better label Feb 28, 2022
This was referenced Mar 10, 2022
Closed
Closed
@leewujung leewujung mentioned this issue Mar 18, 2022
Closed
8 tasks
@emiliom emiliom mentioned this issue Mar 24, 2022
Merged
@emiliom emiliom mentioned this issue Apr 6, 2022
Merged
@emiliom
Copy link
Collaborator Author

emiliom commented Apr 9, 2022

This issue has been addressed. Closing

@emiliom emiliom closed this as completed Apr 9, 2022
Repository owner moved this from In Progress to Done in Echopype Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This makes echopype better
Projects
Echopype
Status: Done
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@emiliom @leewujung