Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echopype publishes python-3.12 packages eventhough it is not compatible with python-3.12 #1418

Closed
peter-urban opened this issue Dec 17, 2024 · 3 comments · Fixed by #1419
Closed
Assignees
Milestone

Comments

@peter-urban
Copy link

Echopype provides conda-forge and pypi packages for python 3.12 (and probably even 3.13 and 3.14) even though it is not compatible (#1408). This creates difficult-to-understand problems (e.g. #1415).

Given that echopype has such an extensive ci-test-suit that would easily catch such issues, the maximum version for published packages on pypi and conda should be set to the maximum python-version used in the ci-test suit. I am not familiar with build/publish procedure applied, but is it possible to specify a maximum (and also minimum) python version for the package? (e.g. the requires-python field in [project] section of the pyproject.toml (https://peps.python.org/pep-0621/)

@peter-urban peter-urban changed the title Maximum python-version number for published echopype packages Echopype publishes python-3.12 packages eventhough it is not compatible with python-3.12 Dec 17, 2024
@ctuguinay ctuguinay self-assigned this Dec 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Dec 26, 2024
@ctuguinay ctuguinay added this to the v0.9.1 milestone Dec 26, 2024
@ctuguinay
Copy link
Collaborator

Oh yeah let me try specifying minimum python version in pyproject.toml. I'll also work on supporting Python 3.12 these next few days.

@leewujung
Copy link
Member

leewujung commented Dec 26, 2024

Our current test matrix only goes up to 3.11, so the errors are not caught. We know that it is likely the datatree upgrade of xarray that triggered these conflicts, which makes this a bigger task (see #1405 and #1408) -- I think a better approach here would be to keep up with the version upgrade instead of just setting the max python version, since that'll likely very soon lead to other version conflicts with other packages.

@ctuguinay thanks for taking this on!

@leewujung
Copy link
Member

leewujung commented Dec 27, 2024

Related to this - I just realized that the batch of latest changes in the installation doc page is not in the stable RTD version folks see, but in latest since we have not released for a while. In that page we have a warning about 3.12 not being supported.

Since it's been so long, I think we can just wait for #1419 and then release. I changed my mind... it's probably better to just release existing changes with a max python version cap, since the xarray datatree migration can be pretty involved and WILL introduce breaking changes, seeing what's in the migration guide. I'll do that soon.

@leewujung leewujung modified the milestones: v0.9.1, v0.10.0 Dec 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants