-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echopype publishes python-3.12 packages eventhough it is not compatible with python-3.12 #1418
Comments
Oh yeah let me try specifying minimum python version in |
Our current test matrix only goes up to 3.11, so the errors are not caught. We know that it is likely the datatree upgrade of xarray that triggered these conflicts, which makes this a bigger task (see #1405 and #1408) -- I think a better approach here would be to keep up with the version upgrade instead of just setting the max python version, since that'll likely very soon lead to other version conflicts with other packages. @ctuguinay thanks for taking this on! |
Related to this - I just realized that the batch of latest changes in the installation doc page is not in the
|
Echopype provides conda-forge and pypi packages for python 3.12 (and probably even 3.13 and 3.14) even though it is not compatible (#1408). This creates difficult-to-understand problems (e.g. #1415).
Given that echopype has such an extensive ci-test-suit that would easily catch such issues, the maximum version for published packages on pypi and conda should be set to the maximum python-version used in the ci-test suit. I am not familiar with build/publish procedure applied, but is it possible to specify a maximum (and also minimum) python version for the package? (e.g. the requires-python field in [project] section of the pyproject.toml (https://peps.python.org/pep-0621/)
The text was updated successfully, but these errors were encountered: