Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Start to End Lazy Loaded / Delayed Computation for compute_Sv #1312

Closed
3 tasks done
ctuguinay opened this issue Apr 24, 2024 · 2 comments
Closed
3 tasks done
Assignees
Labels
enhancement This makes echopype better feature request
Milestone

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Apr 24, 2024

From the conversation regarding the merged PR #1302, it's clear that a user cannot run a fully delayed compute_Sv on EK80 Broadband Complex data, and having a fully delayed compute_Sv would be very nice since it allows further scalability.

The following tasks are needed to make this happen:

  • Check the status of EK60 and EK80 CW data calibration: Can they be done fully delayed? If they cannot, identify and fix any forced computation.
  • Look into Failure to perform compute_Sv with dask inputs #1212. This is delayed computation, but memory leaks.
  • Modify compress_pulse to not have any .compute(). Might be as simple as just not calling it.

I'm leaving this as 1 issue to be done for Milestone 0.9.0, but this can be done in separate PRs and different milestones if it becomes too much for one PR, which it probably will.

@ctuguinay ctuguinay added enhancement This makes echopype better feature request labels Apr 24, 2024
@ctuguinay ctuguinay added this to the v0.9.0 milestone Apr 24, 2024
@ctuguinay ctuguinay self-assigned this Apr 24, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Apr 24, 2024
@ctuguinay ctuguinay changed the title Enable End to End Lazy Loaded / Delayed Computation for compute_Sv Enable Start to End Lazy Loaded / Delayed Computation for compute_Sv Apr 24, 2024
@leewujung
Copy link
Member

#1311 addresses the last point. It also includes other components required to handle lazy-loaded EchoData object for calibrating broadband complex data.

@ctuguinay
Copy link
Collaborator Author

Closed by merging of #1311 and #1331

@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This makes echopype better feature request
Projects
Status: Done
Development

No branches or pull requests

2 participants