Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add func argument to compute_MVBS #1268

Closed
ctuguinay opened this issue Feb 29, 2024 · 1 comment
Closed

Add func argument to compute_MVBS #1268

ctuguinay opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
enhancement This makes echopype better feature request

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Feb 29, 2024

The addition of the func argument will enable users to specify the aggregation function used by the underlying flox.xarray.xarray_reduce. This func parameter determines how the aggregation is performed on the Sv data array. By default, this function is set to nanmean, but users can opt to use other aggregate functions like mean in the case where they want to NaN any MVBS bin that 'contains' NaN values in the original Sv grid.

One can find all available options for func listed here: https://flox.readthedocs.io/en/latest/generated/flox.xarray.xarray_reduce.html.

@leewujung
Copy link
Member

We close this now with #1269 merged. Also that since compute_MVBS is supposed to be a mean or nanmean function, we don't need to include the flexibility of allowing different func. But the intermediate function under the hood does allow that and we'll likely use them for other processing functions later.

@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This makes echopype better feature request
Projects
Status: Done
Development

No branches or pull requests

2 participants