Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source_Sv_path from add_splitbeam_angle #1237

Closed
leewujung opened this issue Dec 1, 2023 · 0 comments
Closed

Remove source_Sv_path from add_splitbeam_angle #1237

leewujung opened this issue Dec 1, 2023 · 0 comments
Assignees
Milestone

Comments

@leewujung
Copy link
Member

leewujung commented Dec 1, 2023

Right now there is a source_Sv_path variable created within add_splitbeam_angle, which is then used in the add_angle_to_ds function to add the newly computed angle variables to an existing dataset. Wouldn't the way to add new variables be the same for either an xr.Dataset object in memory or lazy-loaded from a path?

This was originally from #1216 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants