Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add depth to allowed dimension in apply_mask #1204

Closed
leewujung opened this issue Oct 28, 2023 · 1 comment
Closed

Add depth to allowed dimension in apply_mask #1204

leewujung opened this issue Oct 28, 2023 · 1 comment
Assignees
@ctuguinay
Labels
processing functions
Milestone
v0.8.4

Comments

@leewujung
Copy link
Member

leewujung commented Oct 28, 2023 •
edited
Loading

Right now mask.apply_mask only allows datasets with range_sample as one of the dimensions along with ping_time and channel (optional). However outputs of compute_MVBS for example would have dimension depth in place of range_sample in the along-range dimension. We need to add depth into the allowed dimension in apply_mask.
@leewujung leewujung added this to the 0.8.2 milestone Oct 29, 2023
@github-project-automation github-project-automation bot moved this to Todo in Echopype Oct 29, 2023
@leewujung leewujung mentioned this issue Nov 13, 2023
Closed
5 tasks
@ctuguinay ctuguinay self-assigned this Nov 21, 2023
@ctuguinay ctuguinay mentioned this issue Nov 22, 2023
Merged
@leewujung leewujung removed this from the 0.8.2 milestone Mar 14, 2024
@leewujung leewujung added this to the v0.8.4 milestone Mar 14, 2024
@ctuguinay
Copy link
Collaborator

Closed with the merging of #1230

@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctuguinay ctuguinay

Labels
processing functions
Projects
Echopype
Status: Done
Milestone
v0.8.4
Development

No branches or pull requests
2 participants
@leewujung @ctuguinay