Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage for XML parameters from >1 phases in AZFP #1171

Closed
leewujung opened this issue Sep 18, 2023 · 6 comments
Closed

Add storage for XML parameters from >1 phases in AZFP #1171

leewujung opened this issue Sep 18, 2023 · 6 comments
Assignees
Labels
data conversion enhancement This makes echopype better

Comments

@leewujung
Copy link
Member

With the new XML parser in #1135, we can now handle more than 1 phase in AZFP data. However, currently only the phase 1 parameters parsed from XML are stored in the Vendor_specific group. I think we can add an additional dimension phase to the XML parameters that are under the different phases to store all the information.

@emiliom
Copy link
Collaborator

emiliom commented Sep 26, 2023

Ideally, we should get an AZFP file that does have >1 phase, for testing. Currently it doesn't look like we do.

@leewujung
Copy link
Member Author

I added one actually, it's already in the CI. I've pointed @praneethratna to it. It is the one Steve Pearce provided.

@emiliom
Copy link
Collaborator

emiliom commented Sep 26, 2023

I just checked the CI_test_data Google Drive folder. Are you referring to azfp/23081211.XML? If so, Steve only sent us the XML file, not the data (01A) file. The folder contains three XML files but only two .01A files.

@leewujung
Copy link
Member Author

Yes, that is the file. I think for testing parsing the XML that is sufficient, but maybe you're thinking about going all the way to the set_vendor part? Maybe we can ask Steve for an example 01A file?

@emiliom
Copy link
Collaborator

emiliom commented Sep 26, 2023

but maybe you're thinking about going all the way to the set_vendor part?

Yup

Maybe we can ask Steve for an example 01A file?

Yeah, hopefully he has the .01A file that goes with the XML file, or another complete set.

@praneethratna
Copy link
Contributor

praneethratna commented Sep 26, 2023

I added one actually, it's already in the CI. I've pointed @praneethratna to it. It is the one Steve Pearce provided.

Yes, I'll actually change the test to use this new file for better testing of new code.

@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data conversion enhancement This makes echopype better
Projects
Status: Done
Development

No branches or pull requests

3 participants