-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage for XML parameters from >1 phases in AZFP #1171
Comments
Ideally, we should get an AZFP file that does have >1 phase, for testing. Currently it doesn't look like we do. |
I added one actually, it's already in the CI. I've pointed @praneethratna to it. It is the one Steve Pearce provided. |
I just checked the |
Yes, that is the file. I think for testing parsing the XML that is sufficient, but maybe you're thinking about going all the way to the |
Yup
Yeah, hopefully he has the .01A file that goes with the XML file, or another complete set. |
Yes, I'll actually change the test to use this new file for better testing of new code. |
With the new XML parser in #1135, we can now handle more than 1 phase in AZFP data. However, currently only the phase 1 parameters parsed from XML are stored in the
Vendor_specific
group. I think we can add an additional dimensionphase
to the XML parameters that are under the different phases to store all the information.The text was updated successfully, but these errors were encountered: