Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore inefficiencies in cal_params.py #1163

Closed
lsetiawan opened this issue Sep 13, 2023 · 3 comments
Closed

Explore inefficiencies in cal_params.py #1163

lsetiawan opened this issue Sep 13, 2023 · 3 comments
Assignees

Comments

@lsetiawan
Copy link
Member

There's a potential inefficiency in EK60 and EK80 'cw' data. See code below of where this might be.

idxmin = np.abs(beam["transmit_duration_nominal"] - vend["pulse_length"]).idxmin(
dim="pulse_length_bin"
)
# fill nan position with 0 (will remove before return)
# and convert to int for indexing
idxmin = idxmin.where(~transmit_isnull, 0).astype(int)

@anantmittal
Copy link
Contributor

Command to run the tests and capture the stdout:
python .ci_helpers/run-test.py --local --pytest-args="-vvrP" echopype/calibrate/cal_params.py

@lsetiawan
Copy link
Member Author

Pytest Run

pytest -vvrP echopype/tests/calibrate/test_cal_params.py::test_get_vend_cal_params_power

@leewujung
Copy link
Member

This issue now is captured more fully in #1200. @lsetiawan @anantmittal : you may wanna close this and copy-paste the above comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants