You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From discussion with @Sohambutala:
Some functions in the subpackage consolidate such as add_location and add_splitbeam_angle have inconsistent support for whether or not non-in-memory Sv or EchoData datasets are allowed as inputs. In a workflow sense it is much better to allow stored netcdf or zarr files that contains these datasets, so we should add the support uniformly for functions in the consolidate.
Some specific notes:
add_splitbeam_angle currently accepts in-memory or stored Sv datasets, but not for EchoData
add_location currently does not accept stored Sv or EchoData datasets
The text was updated successfully, but these errors were encountered:
leewujung
changed the title
consolidate subpackage functions needs accept paths to stored Sv or EchoData datasetsconsolidate subpackage functions need to accept both in-memory or stored datasets
Aug 22, 2023
From discussion with @Sohambutala:
Some functions in the subpackage
consolidate
such asadd_location
andadd_splitbeam_angle
have inconsistent support for whether or not non-in-memorySv
orEchoData
datasets are allowed as inputs. In a workflow sense it is much better to allow stored netcdf or zarr files that contains these datasets, so we should add the support uniformly for functions in theconsolidate
.Some specific notes:
add_splitbeam_angle
currently accepts in-memory or storedSv
datasets, but not forEchoData
add_location
currently does not accept storedSv
orEchoData
datasetsThe text was updated successfully, but these errors were encountered: