Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate subpackage functions need to accept both in-memory or stored datasets #1129

Closed
leewujung opened this issue Aug 22, 2023 · 0 comments
Assignees
Milestone

Comments

@leewujung
Copy link
Member

From discussion with @Sohambutala:
Some functions in the subpackage consolidate such as add_location and add_splitbeam_angle have inconsistent support for whether or not non-in-memory Sv or EchoData datasets are allowed as inputs. In a workflow sense it is much better to allow stored netcdf or zarr files that contains these datasets, so we should add the support uniformly for functions in the consolidate.

Some specific notes:

  • add_splitbeam_angle currently accepts in-memory or stored Sv datasets, but not for EchoData
  • add_location currently does not accept stored Sv or EchoData datasets
@leewujung leewujung added this to the 0.8.1 milestone Aug 22, 2023
@github-project-automation github-project-automation bot moved this to Todo in Echopype Aug 22, 2023
@leewujung leewujung changed the title consolidate subpackage functions needs accept paths to stored Sv or EchoData datasets consolidate subpackage functions need to accept both in-memory or stored datasets Aug 22, 2023
@leewujung leewujung modified the milestones: 0.8.1, 0.8.2 Oct 25, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants