From 5b5d6d882ec75b01d556e1f788d278674a29debd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Sun, 3 Dec 2023 18:10:39 +0000 Subject: [PATCH 01/21] Use DoozyX/clang-format-lint-action to run clang-format faster --- .github/workflows/clang-format-check.yml | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index fb7409876cf..81d1874cdcd 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -17,9 +17,21 @@ jobs: name: Formatting Check runs-on: ubuntu-latest steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 - - name: Run clang-format style check for C/C++/Protobuf programs. - uses: jidicula/clang-format-action@v4.11.0 + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + - uses: DoozyX/clang-format-lint-action@v0.16.2 with: - clang-format-version: '15' - check-path: . + source: "." + clangFormatVersion: 15 + inplace: True + - name: Verify Changed files + uses: tj-actions/verify-changed-files@v16 + id: verify-changed-files + - name: List all changed files tracked and untracked files + run: | + echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" + - uses: actions/upload-artifact@v3 + with: + name: my-artifact + path: | + .clang-format + ${{ steps.verify-changed-files.outputs.changed_files }}" From 1e1e58670208329c04e3a240cbc0bd362f6ab7f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:53:00 +0000 Subject: [PATCH 02/21] CI(clang-format): Run on all pull requests --- .github/workflows/clang-format-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 81d1874cdcd..d08120a617c 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -9,6 +9,7 @@ on: branches: - main - releasebranch_* + - "*" concurrency: group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }} cancel-in-progress: true From 086192fa84a268ac638f3befc5aaed95d9109bf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:53:56 +0000 Subject: [PATCH 03/21] CI(clang-format): Always run upload of changed files artifacts --- .github/workflows/clang-format-check.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index d08120a617c..7d9570fa30c 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -30,9 +30,10 @@ jobs: - name: List all changed files tracked and untracked files run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 + if: always() with: name: my-artifact path: | .clang-format - ${{ steps.verify-changed-files.outputs.changed_files }}" + ${{ steps.verify-changed-files.outputs.changed_files }} From f366a7cc9d200fa7e4096974524fff1148f90ffb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:54:32 +0000 Subject: [PATCH 04/21] CI(clang-format): Update verify-changed-files action --- .github/workflows/clang-format-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 7d9570fa30c..fc6140e53b6 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -25,7 +25,7 @@ jobs: clangFormatVersion: 15 inplace: True - name: Verify Changed files - uses: tj-actions/verify-changed-files@v16 + uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files - name: List all changed files tracked and untracked files run: | From 764274c591b1e7a7d74c684f0dd2a58200e9c332 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:55:16 +0000 Subject: [PATCH 05/21] CI(clang-format): Add a job summary with the list files changed by clang-format --- .github/workflows/clang-format-check.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index fc6140e53b6..65f40dad432 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -30,6 +30,12 @@ jobs: - name: List all changed files tracked and untracked files run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" + { + echo '### Changed files:' + echo '```' + echo '${{ steps.verify-changed-files.outputs.changed_files }}' + echo '```' + } >> "$GITHUB_STEP_SUMMARY" - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: From 7fe15e79a5806dea89f3826cf0b6a81b8bad4080 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:56:16 +0000 Subject: [PATCH 06/21] CI(clang-format): Suggest changes as code comments in PR --- .github/workflows/clang-format-check.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 65f40dad432..72582ad64cf 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -36,6 +36,12 @@ jobs: echo '${{ steps.verify-changed-files.outputs.changed_files }}' echo '```' } >> "$GITHUB_STEP_SUMMARY" + - uses: parkerbxyz/suggest-changes@f5b10bcbfe35840153c0e823095d260d5abad1f9 # v1.0.0 + with: + comment: | + Please commit the suggested changes from clang-format. + + Suggestions can only be added to lines near lines changed in this PR. - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: From 2176ab2b0c1120c80cd90d1a38543f9df57d5d5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:56:39 +0000 Subject: [PATCH 07/21] CI(clang-format): Clear default permissions for GITHUB_TOKEN --- .github/workflows/clang-format-check.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 72582ad64cf..11bd3bec820 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -11,8 +11,7 @@ on: - releasebranch_* - "*" concurrency: - group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }} - cancel-in-progress: true +permissions: {} jobs: formatting-check: name: Formatting Check From 4b02f177ecd275d90997ccc9ab9319582466ed56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 02:57:21 +0000 Subject: [PATCH 08/21] CI(clang-format): Simplify concurrency group --- .github/workflows/clang-format-check.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 11bd3bec820..ada74253388 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -11,6 +11,8 @@ on: - releasebranch_* - "*" concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: ${{ github.ref_protected != true }} permissions: {} jobs: formatting-check: From 7fa228eba5fb52886606e2dda1b189707f2fe090 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:06:22 +0000 Subject: [PATCH 09/21] CI(clang-format): Add a job summary when there are no files changed --- .github/workflows/clang-format-check.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index ada74253388..da03def123f 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -31,6 +31,16 @@ jobs: - name: List all changed files tracked and untracked files run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" + - name: Add job summary without changed files + if: ${{ !steps.verify-changed-files.outputs.files_changed }} + run: | + { + echo "### Changed files:" + echo "No files were changed by clang-format" + } >> "$GITHUB_STEP_SUMMARY" + - name: Add job summary without changed files + if: ${{ steps.verify-changed-files.outputs.files_changed }} + run: | { echo '### Changed files:' echo '```' From 5add8daa4115fd09531d2a625e2692e954f207cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:08:08 +0000 Subject: [PATCH 10/21] CI(clang-format): Update DoozyX/clang-format-lint-action action --- .github/workflows/clang-format-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index da03def123f..e11e3445738 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - - uses: DoozyX/clang-format-lint-action@v0.16.2 + - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 with: source: "." clangFormatVersion: 15 From 0bff5d68b3253510090d331597df4175208e1474 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:14:12 +0000 Subject: [PATCH 11/21] CI(clang-format): Add a job summary when there are no files changed --- .github/workflows/clang-format-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index e11e3445738..1e07495ac36 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -38,7 +38,7 @@ jobs: echo "### Changed files:" echo "No files were changed by clang-format" } >> "$GITHUB_STEP_SUMMARY" - - name: Add job summary without changed files + - name: Add job summary with changed files if: ${{ steps.verify-changed-files.outputs.files_changed }} run: | { From db5e54e7bbd155eb58736f6fd1c70b1f0d25cd25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:14:42 +0000 Subject: [PATCH 12/21] CI(clang-format): Debug outputs of verify-changed-files --- .github/workflows/clang-format-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 1e07495ac36..8edbc478b6c 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -28,6 +28,7 @@ jobs: - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files + - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' - name: List all changed files tracked and untracked files run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" From 4d09b7cea64e7b2b0d63e1360e07fb0641a40aa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:17:40 +0000 Subject: [PATCH 13/21] CI(clang-format): Fix step's conditions to when files are changed or not --- .github/workflows/clang-format-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 8edbc478b6c..9b2ee689589 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -33,14 +33,14 @@ jobs: run: | echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" - name: Add job summary without changed files - if: ${{ !steps.verify-changed-files.outputs.files_changed }} + if: ${{ steps.verify-changed-files.outputs.files_changed == 'false' }} run: | { echo "### Changed files:" echo "No files were changed by clang-format" } >> "$GITHUB_STEP_SUMMARY" - name: Add job summary with changed files - if: ${{ steps.verify-changed-files.outputs.files_changed }} + if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} run: | { echo '### Changed files:' From af72158151dd983c011982ad786d3fc1ecfdd857 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:18:57 +0000 Subject: [PATCH 14/21] Add a formatting error in db.copy --- db/db.copy/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 5813cb18f35..1e9af3a20a1 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,7 +18,7 @@ #include #include -int main(int argc, char **argv) +int main(int argc, char **argv) { int ret; struct Option *from_driver, *from_database, *from_table; From 450c6bcb9fc5e6612a1258aa10490c87e61cacb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:21:37 +0000 Subject: [PATCH 15/21] CI(clang-format): Add `pull-requests: write` permission to post comment on PR --- .github/workflows/clang-format-check.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 9b2ee689589..91fe59eda14 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -18,6 +18,8 @@ jobs: formatting-check: name: Formatting Check runs-on: ubuntu-latest + permissions: + pull-requests: write steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 From dc63a826b96c6b160dec8283d8ca31a51b6c7ac8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 03:31:09 +0000 Subject: [PATCH 16/21] CI(clang-format): Temporarily set all permissions to write-all --- .github/workflows/clang-format-check.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 91fe59eda14..8cc9301aa8f 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -13,13 +13,14 @@ on: concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: ${{ github.ref_protected != true }} -permissions: {} +# permissions: {} +permissions: write-all jobs: formatting-check: name: Formatting Check runs-on: ubuntu-latest - permissions: - pull-requests: write + # permissions: + # pull-requests: write steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 From 5e8aa9ef2348e804ceaf38ae5e3043fb87658f59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 04:01:45 +0000 Subject: [PATCH 17/21] CI(clang-format): Use reviewdog/action-suggester to add code suggestions --- .github/workflows/clang-format-check.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 8cc9301aa8f..c5fdaf6f1ae 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -13,14 +13,16 @@ on: concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: ${{ github.ref_protected != true }} -# permissions: {} -permissions: write-all +permissions: {} jobs: formatting-check: name: Formatting Check runs-on: ubuntu-latest - # permissions: - # pull-requests: write + permissions: + contents: read + checks: write + issues: write + pull-requests: write steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - uses: DoozyX/clang-format-lint-action@11b773b1598aa4ae3b32f023701bca5201c3817d # v0.17 @@ -51,12 +53,11 @@ jobs: echo '${{ steps.verify-changed-files.outputs.changed_files }}' echo '```' } >> "$GITHUB_STEP_SUMMARY" - - uses: parkerbxyz/suggest-changes@f5b10bcbfe35840153c0e823095d260d5abad1f9 # v1.0.0 + - name: "Add code suggestions" + uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: - comment: | - Please commit the suggested changes from clang-format. - - Suggestions can only be added to lines near lines changed in this PR. + tool_name: clang-format + fail_on_error: true - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: From d6f33f4787dfdbd8825bdf8b3f30b76bccc2565c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 06:04:44 +0000 Subject: [PATCH 18/21] CI(clang-format): Use git ls-files to get the list of files changed, one per line --- .github/workflows/clang-format-check.yml | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index c5fdaf6f1ae..9d6aacd27f4 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -33,10 +33,16 @@ jobs: - name: Verify Changed files uses: tj-actions/verify-changed-files@d774a4c7ebe335445d79c7b44138f56a76058ba0 # v19.0.0 id: verify-changed-files - - run: echo '${{toJson(steps.verify-changed-files.outputs)}}' + - id: git-changed-files + run: | + { + echo 'CHANGED_FILES<> "$GITHUB_OUTPUT" - name: List all changed files tracked and untracked files run: | - echo "Changed files: ${{ steps.verify-changed-files.outputs.changed_files }}" + echo "Changed files: ${{ steps.git-changed-files.outputs.CHANGED_FILES }}" - name: Add job summary without changed files if: ${{ steps.verify-changed-files.outputs.files_changed == 'false' }} run: | @@ -50,18 +56,21 @@ jobs: { echo '### Changed files:' echo '```' - echo '${{ steps.verify-changed-files.outputs.changed_files }}' + echo "${CHANGED_FILES}" echo '```' } >> "$GITHUB_STEP_SUMMARY" - - name: "Add code suggestions" + env: + CHANGED_FILES: ${{ steps.git-changed-files.outputs.CHANGED_FILES }} + - name: Add code suggestions uses: reviewdog/action-suggester@3d7fde6859623ad6174df5fd662677a0eb63310a # v1.11.0 with: tool_name: clang-format fail_on_error: true + cleanup: false - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: name: my-artifact path: | .clang-format - ${{ steps.verify-changed-files.outputs.changed_files }} + ${{ steps.git-changed-files.outputs.CHANGED_FILES }} From e070803482c5f5880f477cb6ba9235bbf8e44e9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 06:06:00 +0000 Subject: [PATCH 19/21] CI(clang-format): Add extra explanations in the job summary on how to use the artifact to replace with fixed files --- .github/workflows/clang-format-check.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 9d6aacd27f4..5fe6cac3375 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -67,6 +67,15 @@ jobs: tool_name: clang-format fail_on_error: true cleanup: false + - name: Explain that more files need to be fixed + if: ${{ steps.verify-changed-files.outputs.files_changed == 'true' }} + run: | + { + echo '' + echo 'Suggestions can only be added near to lines changed in this PR.' + echo 'All these fixed files are included in the artifact. The artifact can be downloaded and copied to the the repository to replace unformatted files with the formatted files.' + } >> "$GITHUB_STEP_SUMMARY" + exit 1 - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1 if: always() with: From 3bb94a54ed4a167e3aee4e16d924e8ffb8b8bb63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 16:07:35 -0500 Subject: [PATCH 20/21] Revert: Add a formatting error in db.copy --- db/db.copy/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/db.copy/main.c b/db/db.copy/main.c index 1e9af3a20a1..5813cb18f35 100644 --- a/db/db.copy/main.c +++ b/db/db.copy/main.c @@ -18,7 +18,7 @@ #include #include -int main(int argc, char **argv) +int main(int argc, char **argv) { int ret; struct Option *from_driver, *from_database, *from_table; From acce7f47d2b14b4d76ff21ca29911a3405925ec6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Wed, 6 Mar 2024 16:12:26 -0500 Subject: [PATCH 21/21] CI(clang-format): Add workflow_dispatch to allow running manually --- .github/workflows/clang-format-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 5fe6cac3375..5d9ac09a065 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -10,6 +10,7 @@ on: - main - releasebranch_* - "*" + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: ${{ github.ref_protected != true }}