Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Supported versions of wxPython or drop support for non wxPython Phoenix? #4890

Open
echoix opened this issue Dec 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request GUI wxGUI related

Comments

@echoix
Copy link
Member

echoix commented Dec 27, 2024

Is your feature request related to a problem? Please describe.
I am asking to see what "super old" wxPython version is too old.
This fall, some places that checked for really old wxPython/wxWidgets versions were dropped. Should we be doing the same and only support the wxPython "Phoenix", the 2018 rewrite that we use now?

What active plateforms need a next year latest version of GRASS that doesn't have at least a version 4 of wxPython?

Supporting before and after that project means essentially supporting two different places to import our classes, as some are placed a bit everywhere, and we also special-case some other functions a bit everywhere too

Describe the solution you'd like
Only support wxPython "Phoenix" in the latest main branch (developpement) for future releases, and drop special handling.

Describe alternatives you've considered
Status quo.

Additional context
Some static analysis is harder to do, as some classes have a base class coming from an import done inside a conditional block, and that condition is from another import that is the result of a function call, so no static analysis there. This means that there are multiple "Argument to class must be a base class" that prevent full analysis of available methods in classes.

@echoix echoix added enhancement New feature or request GUI wxGUI related labels Dec 27, 2024
@ninsbl
Copy link
Member

ninsbl commented Dec 27, 2024

wxpython>=4 seems quite common: https://repology.org/project/python%3Awxpython/versions

@wenzeslaus
Copy link
Member

Based on the repology link, >=4 looks safe in general.

Ubuntu 20.04 (standard maintenance ends 2025) seems to have both v3 and v4.

@petrasovaa
Copy link
Contributor

Yes, we can drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related
Projects
None yet
Development

No branches or pull requests

4 participants