-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python bindings: implement __arrow_c_stream__() interface for ogr.Layer #9043
Conversation
1377183
to
1c52f84
Compare
|
||
with pytest.raises(Exception, match="requested_schema != None not implemented"): | ||
# "something" should rather by a PyCapsule with an ArrowSchema... | ||
lyr.__arrow_c_stream__(requested_schema="something") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think requested_schema
was added for future-proofing, but no one implements it yet. So it's fine to ignore
This is awesome! The |
Confirmed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
a535ca2
to
e4f78be
Compare
@kylebarron Just seeing your yesterday toot https://mapstodon.space/@kylebarron/111723196242600250 , I gave this a try. I don't necessarily have a way to test that beyond the simple unit tests I added