Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for default tiff ovrview blocksize (#1611) #3052

Merged
merged 1 commit into from
Oct 13, 2020
Merged

add test for default tiff ovrview blocksize (#1611) #3052

merged 1 commit into from
Oct 13, 2020

Conversation

tbonfort
Copy link
Member

test never added for #1611, doing this now. fails locally, awaiting ci tests.

@rouault
Copy link
Member

rouault commented Oct 13, 2020

@tbonfort Any idea why it fails locally for you ? I can only think to GDAL_TIFF_OVR_BLOCKSIZE being defined in your environment

@tbonfort
Copy link
Member Author

it's not the only test to fail, I have 15% failures on tiff_write, not only related to blocksize. It might be because I have a minimal build, but strange nonetheless.

@rouault rouault merged commit f5e5738 into OSGeo:master Oct 13, 2020
@tbonfort
Copy link
Member Author

For the record, tests where picking up the system version of gdal/python instead of the one I compiled in a non standard directory. When compiling gdal with --prefix=$foo the tests should be ran with PYTHONPATH=$foo/lib/python3/dist-packages LD_LIBRARY_PATH=$foo/lib . I couldn't find this documented anywhere, should it be?

@tbonfort tbonfort deleted the default-ovr-blocksize-test branch October 13, 2020 10:27
@rouault
Copy link
Member

rouault commented Oct 13, 2020

When compiling gdal with --prefix=$foo the tests should be ran with PYTHONPATH=$foo/lib/python3/dist-packages LD_LIBRARY_PATH=$foo/lib . I couldn't find this documented anywhere, should it be?

doc/source/contributing/developer.rst suggests to use . scripts/setdevenv.sh (it might pick the wrong python version if you have both python and python3 in your path though), which avoids to run "make install" when developing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants