Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not specify what functions are allowed in ISR #68

Open
prototypicalpro opened this issue Feb 6, 2020 · 1 comment
Labels
Documentation An issue relating to Loom's documentation.

Comments

@prototypicalpro
Copy link
Member

prototypicalpro commented Feb 6, 2020

Describe the bug
When writing an ISR using the Interrupt manager, it is not clear which functions are safe to use in an ISR (e.g. interrupt safe). While there is an Arduino documentation page for this (https://www.arduino.cc/reference/en/language/functions/external-interrupts/attachinterrupt/), the ability to create check flag interrupts means these standard rules are changed in certain conditions (volatile keyword?). To fix this, we should specify a list (or a general rule) of which operations are allowed to be used in an ISR for each type of ISR Loom allows.

@prototypicalpro prototypicalpro added the bug Something isn't working label Feb 6, 2020
@prototypicalpro
Copy link
Member Author

Upon discussion, it was decided that Loom would discontinue support for SAMD immediate ISRs, and only provide an API for the check flag style. This decisions was made to minimize the amount of programming proficiency required to create an ISR, and due to the lack of instances in which a true immediate ISR is needed.

@MrKangs MrKangs self-assigned this Apr 1, 2020
@Cogswatch Cogswatch added the Documentation An issue relating to Loom's documentation. label Apr 1, 2020
@MrKangs MrKangs added this to the Spring Term milestone Apr 1, 2020
@MrKangs MrKangs removed this from the Spring Term milestone Aug 6, 2020
@MrKangs MrKangs removed their assignment Sep 16, 2020
@MrKangs MrKangs removed the bug Something isn't working label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation An issue relating to Loom's documentation.
Projects
None yet
Development

No branches or pull requests

3 participants