Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TpmError headers #2

Open
NickDarvey opened this issue Dec 3, 2024 · 3 comments
Open

TpmError headers #2

NickDarvey opened this issue Dec 3, 2024 · 3 comments

Comments

@NickDarvey
Copy link

There's references to TpmError.h but I can't find that in this repo, nor in ms-tpm-20-ref. Where can I find these?

#include "TpmError.h"

@jenswi-linaro
Copy link
Contributor

jenswi-linaro commented Dec 4, 2024

This commit microsoft/ms-tpm-20-ref@ee21db0 removed it.

The latest on optee_ftpm needs to be built with a certain version of ms-tpm-20-ref, currently it's set to 98b60a44aba79b15fcce1c0d1e46cf5918400f6a since that was the latest when I started to work in optee_ftpm.
This is tracked automatically when using the repo setup, for an example see https://optee.readthedocs.io/en/latest/building/devices/qemu.html#qemu-v8

@jclds139
Copy link

The latest on optee_ftpm needs to be built with a certain version of ms-tpm-20-ref, currently it's set to 98b60a44aba79b15fcce1c0d1e46cf5918400f6a since that was the latest when I started to work in optee_ftpm. This is tracked automatically when using the repo setup, for an example see https://optee.readthedocs.io/en/latest/building/devices/qemu.html#qemu-v8

Given that this is the case, is there a particular reason not to just reference microsoft/ms-tpm-20-ref@98b60a44 as a submodule in this repo, rather than requiring it to be checked out separately to the correct version?

@jenswi-linaro
Copy link
Contributor

We use repo instead of git submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants