-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synchronous execute function #186
Conversation
Testing Github Copilot Workspace. |
b00d272
to
39079c3
Compare
@ospfranco if you don't mind having a look. I have near zero experience with JSI or C++, this implementation was done 90% by AI given the instructions you posted here: #173 (comment) I had to manually remove a couple mistakes the AI made, but other than that, it looks pretty darn good to my eyes. |
I couldn't really run the JS / react-native tests, I think my environment is not setup correctly. Instructions on how to setup the dev environment could me useful. I'll mark this ready for review for the CI to run the tests. |
Oh, and if the code is garbage, please feel free to close this. In that case, I apologize for the noise :) |
It's wrong. But if you don't mind, I'm waiting for Rodrigo to take a look. There's more behind it than just code. Thanks anyways! |
Great news, maybe us developers get to keep our jobs for a bit longer then 😛 |
hi @ospfranco - do you think we can give it priority? we're using the sync version and it will require us to make some changes. also, what will be the performance gain when using async compared to sync? will it clone the object for example? |
There is no performance difference between async and sync, at most there is a small penalty to schedule work on the JS runtime, the code is the same with the exception it's executed in a different thread. We will get to it when we can, we are just busy with paid work atm. |
Fixes #173
Add synchronous execute API to the project.
executeSync
function for synchronous execution.opsqlite_execute
without usinginvokeAsync
.executeSync
function in the function map.executeSync
function for synchronous execution.libsql_query_stmt
without usinglibsql_prepare
.executeSync
function.executeSync
function.executeSync
function.For more details, open the Copilot Workspace session.