Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing GA click events to templates #1342

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Add missing GA click events to templates #1342

merged 2 commits into from
Mar 27, 2024

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Mar 27, 2024 •
edited
Loading

What is the context of this PR?

This PR adds all the remaining GA events and sets all events in Runner to either click or error according to our Analytics doc.

How to review

Test if the GA events are picked up in Analytics or Tag Assistant.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@petechd petechd marked this pull request as ready for review March 27, 2024 11:39
MebinAbraham
MebinAbraham approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to have data-ga set now. 👍

@MebinAbraham MebinAbraham added the Bug Fix Something isn't working label Mar 27, 2024
Yuyuutsu
Yuyuutsu approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Yuyuutsu Yuyuutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petechd petechd merged commit c9df847 into main Mar 27, 2024
16 checks passed
@petechd petechd deleted the add-all-remaining-click-and-error-ga-events branch March 27, 2024 14:13
@petechd petechd mentioned this pull request Apr 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuyuutsu Yuyuutsu Yuyuutsu approved these changes

@berroar berroar berroar approved these changes

@MebinAbraham MebinAbraham MebinAbraham approved these changes

Assignees
No one assigned
Labels
Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petechd @MebinAbraham @berroar @Yuyuutsu