Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation websocket updates are big #535

Open
tgandrews opened this issue Jul 25, 2019 · 0 comments
Open

Validation websocket updates are big #535

tgandrews opened this issue Jul 25, 2019 · 0 comments

Comments

@tgandrews
Copy link
Contributor

Expected behaviour

We should send only the changes in validation after the update.

Actual behaviour

Currently we send the count of validation errors for all sections and pages in the questionnaire.

Steps to reproduce the behaviour

Cause an update to a questionnaire

Technical information

We the questionnaire validation state before and after the update so we should be able to calculate the difference which would significantly reduce the amount of information we are sending to the client.

This however is a trade off of server side CPU vs client side network and CPU cost. Which might not be worth it until people are editing large surveys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant