fix: 🐛 Make crosshair handle thickness configurable. fix bug #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JamesAPetts
commented
Oct 20, 2020
JamesAPetts
commented
- Crosshairs thinner
- Rotate handle smaller
- Rotate handle only appears on mouse over of the line/handle, or during rotation.
- You can no longer scroll the crosshairs offscreen.
Make crosshair handle thickness configurable, and make it less like a child drew it by default. Fix a bug where you scroll the crosshairs offscreen.
|
🎉 This PR is included in version 0.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
radiologics-kate
pushed a commit
to radiologics/react-vtkjs-viewport
that referenced
this pull request
Jan 25, 2021
* fix: 🐛 Make crosshair handle thickness configurable. fix bug Make crosshair handle thickness configurable, and make it look less like a child drew them by default. Fix a bug where you could scroll the crosshairs offscreen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.