-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more NAACCR Variables missing NAACCR Values. #81
Comments
Hello! For Variable 'Type of Reporting Source' I found in NAACCR dictionaty values and they will be added to vocabulary:
As you can see values 1-5 and 8 can be introduced as 'Visit'. We want to give this values domain_id = 'Visit' and do them as standard one, in future it can be mapped to our standard visit concepts. Values 6 and 7 seemes like as 'Type concept', but all data from NAACCR will have 'Tumor Registry' as TYPE_CONCEPT_ID, so we will keep this values as non-standard and with domain 'Meas Value'. |
These should be non-standard Observation.
I have doubts that these values reflect Visit, so let's make it simplier. @mgurley are you agree? |
@dimshitc I agree that the following should be non-standard Observation.
I think the following should be Measurement standard. Remember, most of these NAACCR items are modifying tumor characteristics. And we added 'modifier_of_field_concept_id' and 'modifier_of_event_id' to MEASURMENT to allow for these tumor characteristics to modify their diagnosis parent. If we put it in Observation, we will lose the connection to the diagnosis in CONDITION_OCCURRENCE or EPISODE.
|
all of them - make non standard Observation |
It is possible that this is cruft that we should curate away but right now they are standard concepts and because they have no values, they can't be ETLed:
The text was updated successfully, but these errors were encountered: