Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cohort_attribute table is deprecated #87

Open
gowthamrao opened this issue Mar 29, 2020 · 1 comment
Open

cohort_attribute table is deprecated #87

gowthamrao opened this issue Mar 29, 2020 · 1 comment

Comments

@gowthamrao
Copy link
Member

gowthamrao commented Mar 29, 2020 •
edited
Loading

cohort_attribute table is deprecated in CDM 6, but is referenced in this package in 'Creating covariates using cohort attributes'

OHDSI/CommonDataModel#212

Covariates using cohort attributes is an important and useful functionality. We just need a new home for the cohort_attribute table, or drop reference to CDM - as CDM does not have these tables.

https://github.com/OHDSI/CommonDataModel/blob/v5.3.1_fixes/Documentation/CommonDataModel_Wiki_Files/StandardizedDerivedElements/COHORT_ATTRIBUTE.md

https://github.com/OHDSI/CommonDataModel/blob/v5.3.1_fixes/Documentation/CommonDataModel_Wiki_Files/StandardizedVocabularies/ATTRIBUTE_DEFINITION.md
@schuemie
Copy link
Member

Yes, we should drop the reference to the CDM, and just clearly define the structure of the cohort_attribute table we need.

@gowthamrao gowthamrao mentioned this issue Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schuemie @gowthamrao