-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of Measurement Records Exceed Integer Id Limit #198
Comments
I'm surprised this hasn't been an issue before now. |
No problem to use big_int. Won't make a difference in querying in 99% of the cases, particularly if the IDs are exclusively used for foreign keys. |
I like the idea of converting all key fields to bigint. E.g. person_id, visit_occurrence_id etc. This will need changes to the omop ddl. |
I think we have been using bigint for some of our keys, especially for the MarketScan data. It makes sense to add it in to the DDL; I'll just need to figure out how to translate that translates to bigquery and impala. |
We see this mainly affecting the DDL, no need to update the WIKI. |
BIGINT sounds like a great idea. I use 32 Bytes for my keys on some projects, to accommodate 256b hash values. Yes, I realize that 32B would be overkill for a default allocation for keys. :) |
so this issue should be closed, right? |
I just checked the cdm_v6 branch and it looks good to close. Thanks everyone! |
We've run into an issue where we have more measurement records than an integer measurement_id allows in OMOP database (Over 3 billion where max 32 bit integer is 2,147,483,647). Our suggestion is to change the measurement_id field (and probably the id fields for other domains) to use a 64 bit integer. We are using PostgreSQL for our database.
The text was updated successfully, but these errors were encountered: