Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDM v5.4 typos #702

Open
MelaniePhilofsky opened this issue Jul 15, 2024 · 0 comments
Open

CDM v5.4 typos #702

MelaniePhilofsky opened this issue Jul 15, 2024 · 0 comments

Comments

@MelaniePhilofsky
Copy link
Collaborator

I went looking for specific information about units and found the following incorrect verbiage in the CDM v5.4 documentation:

  1. Observation.unit_source_value; ETL conventions = 'This code is mapped to a Standard Condition Concept in the Standardized Vocabularies and the original code is stored here for reference.'
  2. Observation.qualifier_source_value; ETL conventions = 'This code is mapped to a Standard Condition Concept in the Standardized Vocabularies and the original code is stored here for reference.'
  3. Measurement.operator_concept_id, ETL conventions = 'Operators are =, > and these concepts belong to the ‘Meas Value Operator’ domain.' Should read 'Operators are =, <, and > and these concepts belong to the ‘Meas Value Operator’ domain.'
  4. The standard concept_id fields for each table should state "The standard *CONCEPT_ID that the *SOURCE_CONCEPT_ID maps to." Currently, the ETL conventions state some version of "The CONCEPT_ID that the *_SOURCE_VALUE maps to."
  5. The Device.device_concept_id is lacking a link to the acceptable concepts for the field.
  6. Device.device_start_datetime; ETL conventions = 'This is not required, though it is in v6. If a source does not specify datetime the convention is to set the time to midnight (00:00:0000)'. We should strike mention of V6 since it has been deprecated. We don't want to confuse new users. And since datetime fields are not required, we shouldn't give guidance to set the time to midnight.
  7. Device.unit_source_value; ETL conventions = 'This code is mapped to a Standard Condition Concept in the Standardized Vocabularies and the original code is stored here for reference.'. Should be 'This code is mapped to a Standard Unite Concept in the Standardized Vocabularies and the original code is stored here for reference."
  8. Death.cause_concept_id; ETL conventions; 'There is no specified domain for this concept, just choose the Standard Concept Id that best represents the person’s cause of death.'. This should read 'The standard *CONCEPT_ID that the *SOURCE_CONCEPT_ID maps to. There is no specified domain for this concept.'
    10 . All datetime fields in the CDM should give the following ETL conventions: 'If time is not given, then leave NULL.' since this is not a required field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants