Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #294

Open
matsvanes opened this issue Oct 16, 2024 · 1 comment
Open

Documentation improvements #294

matsvanes opened this issue Oct 16, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@matsvanes
Copy link
Collaborator

Please keep track of documentation problems (especially tutorials) here.

@matsvanes matsvanes added the documentation Improvements or additions to documentation label Oct 16, 2024
@cgohil8
Copy link
Collaborator

cgohil8 commented Oct 25, 2024

The static AEC tutorial (https://osl-dynamics.readthedocs.io/en/latest/tutorials_build/static_aec_analysis.html) calculates AEC using:

methods = {
    "filter": {"low_freq": 7, "high_freq": 13},
    "amplitude_envelope": {},
    "standardize": {},
}

I think maybe it should be:

methods = {
    "standardize": {},
    "filter": {"low_freq": 7, "high_freq": 13},
    "amplitude_envelope": {},
}

I.e. the raw data is standardised but the amplitude envelopes are left are they are. I'm not completely sure what the most standard/common approach is.

Note, the amplitude envelopes are used to calculate functional connectivity (correlation) matrices after this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants