Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage badge and link to test report #802

Closed
Stephen-Gates opened this issue May 23, 2018 · 7 comments
Closed

Add test coverage badge and link to test report #802

Stephen-Gates opened this issue May 23, 2018 · 7 comments
Labels
f:Feature-request This issue is a request for a new feature i:Tests Issues about automated testing
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Add test coverage badge to readme and link from the badge the test report (potentially published on github pages)

@Stephen-Gates Stephen-Gates added f:Feature-request This issue is a request for a new feature i:Tests Issues about automated testing labels May 23, 2018
@Stephen-Gates Stephen-Gates added this to the v0.18.0 milestone May 23, 2018
ghost pushed a commit that referenced this issue Jun 20, 2018
@ghost
Copy link

ghost commented Jun 20, 2018

All boilerplate in place - just need to overcome ci time limit of 60 mins

@Stephen-Gates
Copy link
Contributor Author

Do the tests take that long to run?

@ghost
Copy link

ghost commented Jun 20, 2018

@Stephen-Gates
That's for everything (ie: all tests):
includes the vm setup, node installation,
but yes remembering that there are hundreds of scenarios in there (including ones not defined yet),
and that there's time to bring up the app and wait for elements to be present, 60 mins or more not unusual for everything.

@ghost
Copy link

ghost commented Jun 20, 2018

I'll look at this on and off now that we're at a close (as executing large number tests doesn't take much - just going back every now and then to see if it worked)

  • we can get around this in Travis I think as it allows for common build and then running matrix in parallel (have done it before in java so probably also available for node.js) - but this would be testing only on mac osx.
  • problem is appveyor don't allow parallel execution on OS plan :( But there might be other ways to do this (and would prefer to have tests running regularly in some way on Windows as this includes large number of users for this app).

@Stephen-Gates
Copy link
Contributor Author

@mattRedBox Should we close this issue and make another for the time issue so the milestone can be closed?

@ghost
Copy link

ghost commented Jun 25, 2018

hi @Stephen-Gates
yes sounds good - as we have what we need to create badges now - I'm thinking for the timeout/lack of concurrent builds in appveyor problem (as there doesn't seem to be another way with appveyor) that we:

  • lock down master so that it can only receive pull requests and put github 'checks' in place (already set some of this up)

  • when pushing to master the checks will be the code linter and the tests run, so that:

  • run unit and acceptance tests in Travis (the OS license allows us to cache builds, run tests in parallel, etc so time shouldn't be an issue)

  • when the Travis tests run successfully, run script which checks out branch for each test feature/folder and commit

  • have a generic appveyor config in all branches, so that when these branches are created and committed they trigger an appveyor build -> this will cause a significant number of separate jobs against appveyor, so will potentially take even longer this way (unless I find out that we can cache an appveyor build somehow) - as each test will run sequentially, but it means that we can get around the timeout/concurrency issue by running multiple appveyor builds (but sequentially)

The final step then would be for successful tests to somehow trigger:

  • the tagging after all of these run successfully

The artifacts build of course would still apply only to a created tag.

  • should be about half a day to a day's work -> mostly just to wait for multiple builds and tests to run and iron out any gotchas.

@ghost
Copy link

ghost commented Nov 1, 2018

Note:
https://blog.travis-ci.com/2018-10-11-windows-early-release
Might be simpler to wait for beta-testing (ie: others, before introducing here) and scrap appveyor for travis (more flexibility for matrix jobs)

ghost pushed a commit that referenced this issue Apr 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:Feature-request This issue is a request for a new feature i:Tests Issues about automated testing
Projects
None yet
Development

No branches or pull requests

1 participant