Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Chart.js 3 #443

Open
heathharrelson opened this issue Apr 22, 2021 · 1 comment
Open

Upgrade to Chart.js 3 #443

heathharrelson opened this issue Apr 22, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@heathharrelson
Copy link
Member

Chart.js 3.X has been released. The new release has improved performance, and it supports tree-shaking for significantly reduced bundle sizes. However, it does drop support for IE 11.

Migration guide: https://www.chartjs.org/docs/latest/getting-started/v3-migration.html

@heathharrelson heathharrelson added the dependencies Pull requests that update a dependency file label Apr 22, 2021
@heathharrelson
Copy link
Member Author

Note that Dependabot PRs for Chart.js 3 are currently causing Webpack build failures as shown below. This may be relevant, or it may simply be an artifact of how we have Webpack configured.

ERROR in ./js/chart-config.js 1:0-29
Module not found: Error: Can't resolve 'chart.js' in '/home/runner/work/REDCap-Vizr/REDCap-Vizr/js'
resolve 'chart.js' in '/home/runner/work/REDCap-Vizr/REDCap-Vizr/js'
  Parsed request is a module
  using description file: /home/runner/work/REDCap-Vizr/REDCap-Vizr/package.json (relative path: ./js)
    aliased with mapping 'chart.js': 'chart.js/dist/Chart.js' to 'chart.js/dist/Chart.js'
      Parsed request is a module
      using description file: /home/runner/work/REDCap-Vizr/REDCap-Vizr/package.json (relative path: ./js)
        Field 'browser' doesn't contain a valid alias configuration
        resolve as module
          /home/runner/work/REDCap-Vizr/REDCap-Vizr/js/node_modules doesn't exist or is not a directory
          looking for modules in /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules
            existing directory /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js
              using description file: /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/package.json (relative path: .)
                using description file: /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/package.json (relative path: ./dist/Chart.js)
                  no extension
                    Field 'browser' doesn't contain a valid alias configuration
                    /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/dist/Chart.js doesn't exist
                  .js
                    Field 'browser' doesn't contain a valid alias configuration
                    /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/dist/Chart.js.js doesn't exist
                  .vue
                    Field 'browser' doesn't contain a valid alias configuration
                    /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/dist/Chart.js.vue doesn't exist
                  .json
                    Field 'browser' doesn't contain a valid alias configuration
                    /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/dist/Chart.js.json doesn't exist
                  as directory
                    /home/runner/work/REDCap-Vizr/REDCap-Vizr/node_modules/chart.js/dist/Chart.js doesn't exist
          /home/runner/work/REDCap-Vizr/node_modules doesn't exist or is not a directory
          /home/runner/work/node_modules doesn't exist or is not a directory
          /home/runner/node_modules doesn't exist or is not a directory
          /home/node_modules doesn't exist or is not a directory
          /node_modules doesn't exist or is not a directory
 @ ./node_modules/babel-loader/lib/index.js??clonedRuleSet-1[0].rules[0]!./node_modules/vue-loader/lib/index.js??vue-loader-options!./js/components/Chart.vue?vue&type=script&lang=js& 102:0-50 178:19-35
 @ ./js/components/Chart.vue?vue&type=script&lang=js& 1:0-194 1:210-213 1:215-406 1:215-406
 @ ./js/components/Chart.vue 2:0-57 3:0-52 3:0-52 9:2-8
 @ ./node_modules/babel-loader/lib/index.js??clonedRuleSet-1[0].rules[0]!./node_modules/vue-loader/lib/index.js??vue-loader-options!./js/components/Vizr.vue?vue&type=script&lang=js& 58:0-28 87:11-16
 @ ./js/components/Vizr.vue?vue&type=script&lang=js& 1:0-193 1:209-212 1:214-404 1:214-404
 @ ./js/components/Vizr.vue 2:0-56 3:0-51 3:0-51 9:2-8
 @ ./js/main.js 4:0-37 27:12-16 30:27-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant