Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiver timeline - add GT filters #68

Closed
MareenGeestmann opened this issue Mar 20, 2024 · 5 comments · Fixed by #88
Closed

Quiver timeline - add GT filters #68

MareenGeestmann opened this issue Mar 20, 2024 · 5 comments · Fixed by #88
Assignees

Comments

@MareenGeestmann
Copy link

MareenGeestmann commented Mar 20, 2024

Add filters

  • GT metadata:

  • publication year

  • place of printing

  • (text type)

  • GT labels

@jfrer jfrer self-assigned this Jun 21, 2024
@jfrer
Copy link
Collaborator

jfrer commented Jun 21, 2024

Is the date range (notBefore, notAfter) meant by publication year?
What does the text type mean? Is it "language" or "script"?
Also I can't find the place of printing in the gt metadata.

@jfrer
Copy link
Collaborator

jfrer commented Jun 21, 2024

Another question: should these filters only be added to the timeline view like the filters in #45?

@MareenGeestmann
Copy link
Author

Yes, use the date range for filtering.

Text type refers to "script". (See https://ocr-d.de/gt-metadata/document-your-gt.html under "Document Type".)

Regarding the "place of printing": There is no information on this in the API so far. It may be possible to obtain the place of publication from the METS, but there has been no request for this so far.

Yes, only for timeline view.

@jfrer
Copy link
Collaborator

jfrer commented Jun 25, 2024

Ok, thanks.
The date range filter is already implemented as it was part of #45.

Should I just implement the script-type filter and the label filter then and skip the "place of printing" for now?
Also, just as a notice: The script-type filter won't filter anything at the moment since all the gts have the same script-type "print".

@MareenGeestmann
Copy link
Author

Yes, skip the "place of printing" for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants