Add docker arg for base image and change labels #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertsky
requested changes
Oct 25, 2024
Co-authored-by: Robert Sachunsky <[email protected]>
|
Are you waiting for @kba's review, can we undraft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an argument for the baseimage to the Dockerfile and changes the docker target in the Makefile accordingly. Like it was done for the other processors.
I am not sure about the labels. Here many labels were available, other what we have for the other processors, were only 4 labels are set. I simply removed all the labels to make it consistent (exect the usual 4 labels) . But I am not sure if this is right so maybe this has to be changed again. Therefore this is only a draft yet.