Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail table creation if table already exists #62

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Conversation

pwinckles
Copy link
Collaborator

No description provided.

@pwinckles pwinckles temporarily deployed to ci January 13, 2022 20:50 Inactive
@pwinckles pwinckles temporarily deployed to ci January 13, 2022 20:50 Inactive
@MormonJesus69420
Copy link
Contributor

One small thing to say, if you are already making changes to the DB systems, could you also change the BLOB to MEDIUMBLOB for the inventory type in MariaDB tmpl file? Since as we discussed it turns out in practice that BLOB is too small.
https://github.com/UW-Madison-Library/ocfl-java/blob/6a17748bfd87b379894b8469e05b403b478ab349/ocfl-java-core/src/main/resources/db/mariadb/ocfl_object_details.ddl.tmpl#L9

@pwinckles
Copy link
Collaborator Author

One small thing to say, if you are already making changes to the DB systems, could you also change the BLOB to MEDIUMBLOB for the inventory type in MariaDB tmpl file? Since as we discussed it turns out in practice that BLOB is too small.

https://github.com/UW-Madison-Library/ocfl-java/blob/6a17748bfd87b379894b8469e05b403b478ab349/ocfl-java-core/src/main/resources/db/mariadb/ocfl_object_details.ddl.tmpl#L9

Yep, I can do that. I'm off today as well, but I'll take care of it tomorrow.

@MormonJesus69420
Copy link
Contributor

No problem, enjoy your time off and do it whenever you have time, we are in no rush here. 🙂

@pwinckles pwinckles temporarily deployed to ci January 18, 2022 14:47 Inactive
@pwinckles pwinckles temporarily deployed to ci January 18, 2022 14:47 Inactive
@pwinckles pwinckles merged commit 9b61f62 into main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants