NTuple Omit Prefix Implementation

[ives1227]

This is the implementation of the recently merged spec https://github.com/OCFL/extensions/blob/main/docs/0007-n-tuple-omit-prefix-storage-layout.md.

[pwinckles]

Thanks for submitting the extension!

[ives1227]

@pwinckles I've addressed all of the above comments and recommitted. Thanks so much for your timely review!

[ives1227]

@pwinckles I'll get to these later tonight or tomorrow. Thanks!

[pwinckles]

I pulled the PR and opened it in my IDE this time (the source of a few the nitpicks here) and noticed that you're using tabs whereas this project uses spaces. At some point I should get a linter setup, but, for now, please replace all tabs with four spaces.

Additionally, I tried to use the new extension and could not because the extension's spec file is missing. You need to add a copy of the extension spec to this directory https://github.com/UW-Madison-Library/ocfl-java/tree/main/ocfl-java-core/src/main/resources/ocfl-specs

[pwinckles]

I just committed some checkstyle rules that you can pickup if you rebase. I'm not a dogmatic code style person, but it is nice if fundamental things like spacing is consistent.

[ives1227]

@pwinckles I made the requested changes again. Thanks for the checkstyles - that helped me clear up the discrepancies.

[pwinckles]

It appears that your PR is now including commits that were made to main. You need to rebase your PR so that it only includes your commits.

[ives1227]

@pwinckles I was just typing this to you. I rebased on main because of the checkstyles and didn't realize it included all of these changes. I'll fix this when I have a chance.

[pwinckles]

@ives1227 I'm hoping to get a release out this week or next. Do you think you'll have time to rebase this PR?

[ives1227]

@pwinckles I will try to get to this in the next day or two. Between the holidays and work demands, I didn't have a chance to look at this.

[ives1227]

@pwinckles I believe this is all set now.

[pwinckles]

You seem to have reverted the PR back to its original state, undoing all of the revisions that were made as part of the review process

[pwinckles]

I created an example branch of what this should look like. Note, that the tabs are still not fixed in that branch.

I created that checking out your branch and doing the following:

# Rebase to remove the three most recent commits
git rebase -i HEAD~4

# Add the upstream if you don't have it
git remote add upstream [email protected]:UW-Madison-Library/ocfl-java.git

# Rebase from upstream
git rebase upstream/main

That should produce the same branch as mine. Then, when you push to origin to update this PR you'll need to use the --force flag.

[pwinckles]

Getting there... There are still pom files that are modified in this PR that should not be

[ives1227]

@pwinckles the files I had previously were 1.4.2-SNAPSHOT but when I rebased from your branch, they were 1.4.3-SNAPSHOT. So, I should be using 1.4.3-SNAPSHOT instead?

[pwinckles]

@pwinckles the files I had previously were 1.4.2-SNAPSHOT but when I rebased from your branch, they were 1.4.3-SNAPSHOT. So, I should be using 1.4.3-SNAPSHOT instead?

Yes, 1.4.3-SNAPSHOT is correct

[ives1227]

@pwinckles I put the correct snapshot version back in.

[pwinckles]

Thank you for the submission!

[ives1227]

@pwinckles thank you!