[16.0][IMP] stock_picking_group_by_max_weight: Split if max weight exceed #1451
Conversation
Split moves into different pickings at assignment time if the total weight of the picking is greater than the maximum weight allowed on the picking type. Prior to this commit only new moves created after the creation of an open picking were put into a new picking upon assignment if the total weight of the picking would exceed the maximum weight allowed on the picking type. This commit improves this behavior by also splitting existing moves into different pickings after the moves have been assigned to a picking. IOW, in a post-assignment step, the system will split picking lines into different pickings when the total weight is exceeded.
lmignon
force-pushed
the
16.0-split-max-weight
branch
from
43dfd0c to
5a13075
Compare
There was a problem hiding this comment.
I don't like the approach. It doesn't look to work properly when moves are added. Post processs is called before action_confirm, so you break the moves merging mechanism of odoo.
You better not split the moves in multiple pickings at this stage.
I would have implemented this at the batch picking creation based on the picking device limit. If the picking weight exceeds the picking device max weight, create a split order (you have the method in shopfloor) containing a subset of the moves within the weight limit.
In your PR here you already have defined the concept of max weight: https://github.com/OCA/wms/pull/534/files#diff-b737ddc38c458efb5b613c33ee65b4cefb4a0fc5b0dc46e93b7712ec34cda478R22
Add the split picking creation as mentioned here : https://github.com/OCA/wms/pull/534/files#r1428768425
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1451-by-rousseldenis-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b4b00c0. Thanks a lot for contributing to OCA. ❤️ |
No description provided.