Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14.0 mig account fiscal year closing #199

Merged
merged 22 commits into from
Aug 11, 2022
Merged

14.0 mig account fiscal year closing #199

merged 22 commits into from
Aug 11, 2022

Conversation

matteoopenf
Copy link
Contributor

fix create and write #169

antespi and others added 21 commits February 16, 2022 17:45
@antespi @SimoRubi
[ADD] account_fiscalyear_closing: Generic engine for closing operations
ffbdd11
@pedrobaeza @SimoRubi
[FIX+IMP] account_fiscal_year_closing
d44512b 
* Included template mechanism
* Remove unused files
* Fix behaviors
* Some refactoring
* Complete features
@JordiBForgeFlow @SimoRubi
migrate account_fiscal_year_closing to 10.0
6956d4a
@oca-transbot @SimoRubi
OCA Transbot updated translations from Transifex
cd6233c
@sergiocorato @SimoRubi
[12.0][PORT] account fiscal year closing
248c044
@oca-travis @SimoRubi
[UPD] Update account_fiscal_year_closing.pot
68552c3
@OCA-git-bot @SimoRubi
[UPD] README.rst
41abddf
@oca-transbot @SimoRubi
Update translation files
41ad095 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-closing-12.0/account-closing-12.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_fiscal_year_closing/
@oca-transbot @SimoRubi
Update translation files
59deff6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-closing-12.0/account-closing-12.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_fiscal_year_closing/
@alexey-pelykh @SimoRubi
[FIX] account_fiscal_year_closing: tests should not use fixed dates
d7a9f2a
@OCA-git-bot @SimoRubi
[UPD] README.rst
bc2dbfd
@OCA-git-bot @SimoRubi
account_fiscal_year_closing 12.0.1.0.1
331e159
@eLBati @SimoRubi
Translated using Weblate (Italian)
b60449c 
Currently translated at 66.6% (76 of 114 strings)

Translation: account-closing-12.0/account-closing-12.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_fiscal_year_closing/it/
@eLBati @SimoRubi
IMP account_fiscal_year_closing adding multi company rule for account…
3f3cace 
….fiscalyear.closing.template
@OCA-git-bot @SimoRubi
account_fiscal_year_closing 12.0.1.1.0
3240af9
@marcelsavegnago @SimoRubi
Added translation using Weblate (Portuguese (Brazil))
5b34a97
@SimoRubi
[IMP] account_fiscal_year_closing: black, isort, prettier
5c06d00
@SimoRubi
[MIG] account_fiscal_year_closing: Migration to 14.0
1950b68 
Fixed warnings:
Field account.fiscalyear.closing.closing_template_id: unknown parameter 'oldname', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
Field account.move.fyc_id: unknown parameter 'delete', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
The model account.fiscalyear.closing.config has no _description
The model account.fiscalyear.closing.mapping has no _description
The model account.fiscalyear.closing.type has no _description
The model account.fiscalyear.closing.template has no _description
The model account.fiscalyear.closing.config.template has no _description
The model account.fiscalyear.closing.mapping.template has no _description
The model account.fiscalyear.closing.type.template has no _description
The model account.fiscalyear.closing.unbalanced.move has no access rules
The model account.fiscalyear.closing.unbalanced.move.line has no access rules
odoo.addons.base.models.ir_ui_view: Search tag requires at least one field element
The method '_company_default_get' on res.company is deprecated and shouldn't be used anymore
DeprecationWarning: RedirectWarning method 'post()' is a deprecated alias to 'action_post()' or _post()
@SimoRubi
[IMP] account_fiscal_year_closing: Restore onchange on closing's temp…
8e3860e 
…late
@SimoRubi
[IMP] account_fiscal_year_closing: Add date field to unbalanced move …
7011fb0 
…line.

Otherwise the following might happen:
  File "/path/to/odoo/addons/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 328, in button_calculate
    res = self.calculate()
  File "/path/to/odoo/addons/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 315, in calculate
    return self._show_unbalanced_move_wizard(data)
  File "/path/to/odoo/addons/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 295, in _show_unbalanced_move_wizard
    wizard = self.env["account.fiscalyear.closing.unbalanced.move"].create(data)
[...]
ValueError: Invalid field 'date' on model 'account.fiscalyear.closing.unbalanced.move.line'
@matteoopenf
Merge branch '14.0-mig-account_fiscal_year_closing' of https://github…
ee16e44 
….com/SimoRubi/account-closing into 14.0-mig-account_fiscal_year_closing
@matteoopenf matteoopenf mentioned this pull request Jul 13, 2022
Merged
@matteoopenf matteoopenf force-pushed the 14.0-mig-account_fiscal_year_closing branch from 657ffc0 to 7708080 Compare July 13, 2022 09:23
@matteoopenf
Copy link
Contributor Author

@elvise any idea how I can fix travis?
2022-07-13 09:27:25,213 6570 ERROR openerp_test odoo.modules.loading: At least one test failed when loading the modules.
2022-07-13 09:27:25,220 6570 INFO openerp_test odoo.service.server: Starting post tests
2022-07-13 09:27:25,227 6570 INFO openerp_test odoo.addons.account_invoice_start_end_dates.tests.test_invoice_start_end_dates: Starting TestInvoiceStartEndDates.test_invoice ...
2022-07-13 09:27:25,987 6570 INFO openerp_test odoo.service.server: 1 post-tests in 0.77s, 266 queries
2022-07-13 09:27:25,987 6570 ERROR openerp_test odoo.tests.runner: 0 failed, 1 error(s) of 13 tests when loading database 'openerp_test'
2022-07-13 09:27:25,987 6570 INFO openerp_test odoo.service.server: Initiating shutdown
2022-07-13 09:27:25,987 6570 INFO openerp_test odoo.service.server: Hit CTRL-C again or send a second signal to force the shutdown.
2022-07-13 09:27:26,173 6570 INFO openerp_test odoo.sql_db: ConnectionPool(used=0/count=0/max=64): Closed 2 connections

ERROR: setUpClass (odoo.addons.account_fiscal_year_closing.tests.test_account_fiscal_year_closing.TestAccountFiscalYearClosing)
Traceback (most recent call last):
File "/home/travis/odoo-14.0/odoo/tests/common.py", line 173, in _handleClassSetUp
setUpClass()
File "/home/travis/build/OCA/account-closing/setup/account_fiscal_year_closing/odoo/addons/account_fiscal_year_closing/tests/test_account_fiscal_year_closing.py", line 15, in setUpClass
super().setUpClass()
File "/home/travis/odoo-14.0/addons/account/tests/common.py", line 27, in setUpClass
assert 'post_install' in cls.test_tags, 'This test requires a CoA to be installed, it should be tagged "post_install"'
AssertionError: This test requires a CoA to be installed, it should be tagged "post_install"

Module account_fiscal_year_closing: 0 failures, 1 errors of 0 tests
At least one test failed when loading the modules.
0 failed, 1 error(s) of 13 tests when loading database 'openerp_test'
Message not found: 'Modules loaded.'

@matteoopenf matteoopenf force-pushed the 14.0-mig-account_fiscal_year_closing branch from 74a9f59 to a2097ec Compare July 13, 2022 13:18
@matteoopenf
Copy link
Contributor Author

@elvise I fix the problem and all is green and I think now all it is ok

@matteoopenf matteoopenf force-pushed the 14.0-mig-account_fiscal_year_closing branch from a2097ec to fb4c3ee Compare July 13, 2022 13:31
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@matteoopenf
Copy link
Contributor Author

@sergiocorato @SimoRubi is it possibile have a review and after merge?

@matteoopenf
Copy link
Contributor Author

@elvise for you is it ok the pr?
thannk you

@elvise
Copy link

elvise commented Jul 22, 2022

@elvise for you is it ok the pr? thannk you

for me yes

@matteoopenf
Copy link
Contributor Author

@elvise for you is it ok the pr? thannk you

for me yes

can you approve?
Thank you

elvise
elvise approved these changes Jul 22, 2022
View reviewed changes
Copy link

@elvise elvise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francesco-ooops
Copy link
Contributor

@OCA/accounting-maintainers could this be reviewed?

@matteoopenf
Copy link
Contributor Author

@OCA/accounting-maintainers is possibile merge?

@matteoopenf
Copy link
Contributor Author

@SimoRubi @SirTakobi is ok for you?

@matteoopenf
Copy link
Contributor Author

@sergiocorato is ok now for you?

@matteoopenf
Copy link
Contributor Author

@petrus-v review?

@matteoopenf
Copy link
Contributor Author

mde-spring review?

@francesco-ooops
Copy link
Contributor

@OCA/accounting-maintainers any chance to review?

@rafaelbn rafaelbn added this to the 14.0 milestone Aug 5, 2022
@rafaelbn
Copy link
Member

rafaelbn commented Aug 5, 2022

Helllo, I've never used this module. I could review it this weekend if you could record a little video explaining details. I'll try it!

@matteoopenf
Copy link
Contributor Author

matteoopenf commented Aug 8, 2022 •
edited
Loading

Helllo, I've never used this module. I could review it this weekend if you could record a little video explaining details. I'll try it!

Hi, we write a little Manual I attach the manual, said me if all is ok for you
Odoo_-Manuale-_Chiusura_Anno_fiscale.pdf

Thank you

@elvise
Copy link

elvise commented Aug 11, 2022

@pedrobaeza as this is a good for to merge, what do you think about this one?

@pedrobaeza
Copy link
Member

Merging based on existing reviews:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-199-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 22f1e1e into OCA:14.0 Aug 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d4f8263. Thanks a lot for contributing to OCA. ❤️

@mde-scopea mde-scopea mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickt-oforce patrickt-oforce patrickt-oforce approved these changes

@amosdisabatino amosdisabatino amosdisabatino approved these changes

@elvise elvise elvise approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.