Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested new rule for OBO Foundry ontologies: classification within a single model without unsatisfiable classes #482

Open
leechuck opened this issue Sep 14, 2017 · 4 comments
Labels
attn: Operations Committee Issues pertinent to broad Foundry activities, such as policies and guidelines policy Issues and discussion related to OBO Foundry policies

Comments

@leechuck
Copy link
Contributor

The OBO Foundry ontologies are not currently mutually interoperable as there are several thousand unsatisfiable classes when all the ontologies are classified within a single model (see https://github.com/bio-ontology-research-group/oboconsistencytest).

We ( @bill-baumgartner @pbuttigieg and I) would suggest to have a new rule for OBO Foundry (not OBO Library) ontologies: classification within a single model without unsatisfiable classes (at least using ELK).

The main way to enforce this constraint would be to incorporate it into the integration checks for OBO Foundry ontologies, i.e., don't perform classification of the ontology and its imports alone, but import it together with all Foundry ontologies (the full ontologies including all their axioms, not a subset thereof).

Is there any reason why this would not be sensible?

@pbuttigieg
Copy link
Contributor

My main concern is that our ENVO assertions may be breaking things in other resources I can't see in our local build process. I'll have to investigate the explanations that will be generated by @leechuck 's code once more compute is available to be able to comment more .

@balhoff
Copy link
Contributor

balhoff commented Sep 14, 2017

@leechuck I agree and I think we need access to a release of each ontology which includes all axioms, but does not include any pre-reasoned inferences. Many of the release versions of ontologies include a precomputed class hierarchy, which depends on particular versions of imports from external ontologies.

I suggested making available such an artifact for Uberon: obophenotype/uberon#1363

It would also be nice if there were an OBO convention for how to get the full, "raw", version of a given ontology. E.g. for Uberon I suggested the IRI http://purl.obolibrary.org/obo/uberon/raw/uberon.owl.

@alanruttenberg
Copy link
Member

+1 on reasoning on foundry ontologies taken as a whole, and on suggestion by @balhoff that we add purl conventions for some kinds of artifacts. Even better: Have each version of ontology include annotations referring to other available artifacts, so the information is explicit. Added by the build process, of course.

@nlharris nlharris added the policy Issues and discussion related to OBO Foundry policies label Mar 23, 2020
@nlharris nlharris changed the title Suggested new rule for OBO Foundry ontologies Suggested new rule for OBO Foundry ontologies: classification within a single model without unsatisfiable classes Jul 28, 2020
@nlharris nlharris added the attn: Operations Committee Issues pertinent to broad Foundry activities, such as policies and guidelines label Jul 28, 2020
@matentzn
Copy link
Contributor

matentzn commented Mar 9, 2021

In practice, we do now import other ontologies and classify our ontologies with them. I think this is a good step forward; I would suggest a slightly reduced proposal here:

  1. Every ontology SHOULD provide a base
  2. Every ontology primary release MUST be consistent and coherent
  3. Every ontology MUST be coherent when classified together with RO, BFO, and COB
  4. Every ontology SHOULD be coherent when classified together with all its base-dependencies

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attn: Operations Committee Issues pertinent to broad Foundry activities, such as policies and guidelines policy Issues and discussion related to OBO Foundry policies
Projects
None yet
Development

No branches or pull requests

6 participants