Added "device"

[ddooley]

To address #222 . Also added "has function" and "function of", understanding that ultimately they will be imported from RO.

Note domain of "has function" is an 'independent continuant' but COB doesn't have that so are we needing a disjunction of top-level terms to reflect comparable logic?

[ddooley]

I don't know why the cob-edit.owl diff is different. I'm using latest protege 5.6.1. Its coding <owl:annotatedTarget rdf:nodeID="genid58"/> outside of classes they are mentioned in. Maybe that's normal now?!

[cmungall]

We need to have this in the CONTRIBUTING.md but PRs like this should always have corresponding edits to cob-to-external

[cmungall]

can be merged when spurious diffs resolves (note cob has not been 5.6.1 normalized yet) and when cob-to-ext changes in

[matentzn]

• @cmungall as per NTR device, replacing OBI device #222 there should not be an external mapping for this term.
• @ddooley can you rename the PR? it seems has function is NOT added
• I fixed the spurious diff
• Made a PR to Add CONTRIBUTING.md and COC #237

[ddooley]

I've renamed. Forgot that there was shift to using "has characteristic" rather than "has function".

[cmungall]

Go ahead and merge if this is a blocker but I think we need a new SOP for NTRs that replace OBO IDs

proposed here:

• Added "device" #232

[ddooley]

Note that OBI's "device" term is currently specialized to scientific investigations: "A material entity that is designed to perform a function in a scientific investigation, but is not a reagent." so its not an equivalent to the COB device term. I recall OBI will reuse COB's term, and add subclasses for functional kinds of device.