-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename COB 'molecular entity' to 'molecule' #251
Comments
COB's definition covers functional groups, seems a little unintuitive to call these molecules which implies (IMO) wholeness/object/maximally connected (covalently) component? |
(Definitions reproduced/updated here for ease of reference) ChEBI molecular entity: Any constitutionally or isotopically distinct atom, molecule, ion, ion pair, radical, radical ion, complex, conformer etc., identifiable as a separately distinguishable entity. @cmungall I see your point. For me the key aspect of the CHEBI 'molecular entity' definition is "identifiable as a separately distinguishable entity" (which, to my mind, also includes functional groups). More specifically--and key to how I would use these terms--CHEBI's definition allows the inclusion of complexes. The concern for me is a practical one: There has been a proposal (memory now fuzzy on this) that all terms in OBO ontologies must correspond to a term in COB (this was not a requirement when COB was first proposed/discussed; it was proposed later). I actually like and agree with the proposal, but... In PRO, we have what is, in essence, a new upper level term "protein-containing molecular entity" intended to cover individual proteins (and processed parts thereof), protein complexes, and protein aggregates. As things stand now, this term will be free standing, so to speak. That is, there is no COB term that corresponds to it. I was hoping that COB would replicate the spirit of CHEBI's 'molecule' and 'molecular entity'. Of course, if the proposal is not adopted, then PRO can happily stay under CHEBI's molecular entity instead of COB's (with, of course, the ensuing confusion that the identically-named but non-equivalent terms will generate). |
As indicated in #104, COB's 'molecular entity' is much closer in spirit to CHEBI's 'molecule' than to CHEBI's 'molecular entity'. Accordingly, I propose that the current 'molecular entity' in COB be renamed to 'molecule'. It's clearer, less inclined toward misinterpretation, and better fits with the naming for other terms beneath 'material entity'.
The text was updated successfully, but these errors were encountered: