Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The user should be able to customize the diff table labels from the environment #38

Open
NyanKiyoshi opened this issue Jun 10, 2019 · 0 comments
Open

The user should be able to customize the diff table labels from the environment #38

NyanKiyoshi opened this issue Jun 10, 2019 · 0 comments
Labels
feature help wanted Extra attention is needed
Milestone
v1.1.x

Comments

@NyanKiyoshi
Copy link
Owner

Is your feature request related to a problem? Please describe.
Users might get confused by the left and right label, because those labels might make sense for some users but not to all of them. What is left? What is right?

Describe the solution you'd like
As it might be considered as a major change to actually rename those fields, it would be just easier to let the user decide what they want as label using environment variables.

DJ_QUERIES_LEFT_LABEL = "before"
DJ_QUERIES_RIGHT_LABEL = "after"
@NyanKiyoshi NyanKiyoshi added help wanted Extra attention is needed feature labels Jun 10, 2019
@NyanKiyoshi NyanKiyoshi modified the milestones: v1.1.0, v1.0.x Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted Extra attention is needed
Projects
None yet
Milestone
v1.1.x
Development

No branches or pull requests
1 participant
@NyanKiyoshi