Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file(s) #23

Closed
rishabhsingh971 opened this issue Aug 4, 2019 · 10 comments · Fixed by #32
Closed

Config file(s) #23

rishabhsingh971 opened this issue Aug 4, 2019 · 10 comments · Fixed by #32
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rishabhsingh971
Copy link
Member

A config file can be made to store different stuff like:

  • username, password (after informing and taking permission from user)
  • user settings
  • last request time (to override old submission by a new one)
    Also, metadata about each file downloaded can be stored in the same/different config.
@rajat19
Copy link
Member

rajat19 commented Oct 6, 2019

What you want to have in user settings ?

@rajat19
Copy link
Member

rajat19 commented Oct 7, 2019

Also,
how are we planning to store passwords ?
As it would be required to login user
and we can't store it in old plain text

should we store some cookie instead ?

@rishabhsingh971
Copy link
Member Author

rishabhsingh971 commented Oct 7, 2019

What you want to have in user settings ?

some/all of the inputs that can be configured by user (like username, limit, etc)

should we store some cookie instead ?

storing cookie is a good idea
we can also cache the entire session. For that we can either manually pickle session or use https://github.com/rishabhsingh971/persession

@rajat19
Copy link
Member

rajat19 commented Oct 9, 2019

Other than storing cookie/session
everything else is covered in #32

@rishabhsingh971
Copy link
Member Author

storing cookie is a good idea
we can also can cache the entire session. For that we can either manually pickle session or use https://github.com/rishabhsingh971/persession

What do you think about this @rajat19 @rajatgoyal715?

@rajatgoyal715
Copy link
Member

Yeah, sure. It looks like a good idea to me. But just one quick question - what's the expiration time of a cookie in general (like from hackerrank side)? Or there is no expiration time, like will the same cookie (which we'll save once) work every time till eternity?

@rishabhsingh971
Copy link
Member Author

image
From this, I guess expiration time is either 1 year or 1 week (if remember_hacker_token is considered). Maybe @rajat19 can enlighten us?

@rajatgoyal715
Copy link
Member

@rishabhsingh971 You mean 2 weeks in case of remember_hacker_token?

@rishabhsingh971
Copy link
Member Author

I meant 2 weeks, if remember_hacker_token has a role in keeping the user logged in.

@rajatgoyal715
Copy link
Member

@rishabhsingh971 Can you please create a separate issue out of this? IMO we should have this discussion on the new issue, because this issue will be closed by #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants