Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bun #414

Merged
merged 23 commits into from
Mar 17, 2024
Merged

Migrate to bun #414

merged 23 commits into from
Mar 17, 2024

Conversation

holzmaster
Copy link
Collaborator

No description provided.

@holzmaster
Copy link
Collaborator Author

Geht noch nicht wegen node-canvas.

@holzmaster
Copy link
Collaborator Author

Müssen wir auch nich mergen, wollte nur ein Projekt mal nach bun migrieren.

@twobiers
Copy link
Collaborator

twobiers commented Sep 8, 2023

@holzmaster
Copy link
Collaborator Author

node-canvas is rip deshalb:
Automattic/node-canvas#2260

Bun macht wohl kein postInstall oder so (die .node-File wird nicht geladen). Deshalb fehlt die node-Extension.
Wenn man es mit npm installiert, ist sie da. Aber Bun kann mit der Node-Extension nichts anfangen.

Entweder ne fundamentale Inkompabilität oder irgendwas, was besser is, wenn node-canvas irgendwann N-API verwendet: Automattic/node-canvas#923 (comment)

Oder so

@holzmaster
Copy link
Collaborator Author

Nächster Blocker:
sequelize/sequelize#16468

@holzmaster
Copy link
Collaborator Author

node-canvas is rip deshalb:
Automattic/node-canvas#2260

Gelöst in #430

@holzmaster holzmaster marked this pull request as ready for review March 17, 2024 22:54
@holzmaster holzmaster merged commit e629657 into master Mar 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants