From 108ea2df5ed96153bae86f5bad0cbfbfeb46079e Mon Sep 17 00:00:00 2001 From: Rachel Breeze Date: Mon, 31 Aug 2020 20:56:00 +0100 Subject: [PATCH] Made the logviewer more accessible (#8213) --- .../editor/umbeditorheader.directive.js | 12 + .../src/less/components/umb-logviewer.less | 12 + .../src/views/logviewer/overview.html | 65 ++-- .../src/views/logviewer/search.controller.js | 3 +- .../src/views/logviewer/search.html | 280 +++++++++--------- 5 files changed, 199 insertions(+), 173 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js index 58f799e5af71..2cfc6257a205 100644 --- a/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js +++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js @@ -227,6 +227,9 @@ Use this directive to construct a header inside the main editor window. // to make it work for language edit/create setAccessibilityForEditorState(); scope.loading = false; + } else if (scope.name) { + setAccessibilityForName(); + scope.loading = false; } else { scope.loading = false; } @@ -265,6 +268,15 @@ Use this directive to construct a header inside the main editor window. editorService.iconPicker(iconPicker); }; + function setAccessibilityForName() { + var setTitle = false; + if (scope.setpagetitle !== undefined) { + setTitle = scope.setpagetitle; + } + if (setTitle) { + setAccessibilityHeaderDirective(false, scope.editorfor, scope.nameLocked, scope.name, "", true); + } + } function setAccessibilityForEditorState() { var isNew = editorState.current.id === 0 || editorState.current.id === "0" || diff --git a/src/Umbraco.Web.UI.Client/src/less/components/umb-logviewer.less b/src/Umbraco.Web.UI.Client/src/less/components/umb-logviewer.less index 56fa905310ee..32dcccb8da98 100644 --- a/src/Umbraco.Web.UI.Client/src/less/components/umb-logviewer.less +++ b/src/Umbraco.Web.UI.Client/src/less/components/umb-logviewer.less @@ -122,6 +122,11 @@ .table { table-layout: fixed; + table { + display: table; + width: 100%; + } + thead th:first-child, thead th:nth-child(3) { width: 20%; } @@ -130,9 +135,16 @@ width: 15%; } + tr td:nth-child(3) { word-break: break-word; } + + button { + white-space: normal; + word-break: break-word; + text-align-last: left; + } } .exception { diff --git a/src/Umbraco.Web.UI.Client/src/views/logviewer/overview.html b/src/Umbraco.Web.UI.Client/src/views/logviewer/overview.html index 3ce1c0e054dd..3d5dd7f610e9 100644 --- a/src/Umbraco.Web.UI.Client/src/views/logviewer/overview.html +++ b/src/Umbraco.Web.UI.Client/src/views/logviewer/overview.html @@ -7,7 +7,8 @@ name-locked="true" hide-icon="true" hide-description="true" - hide-alias="true"> + hide-alias="true" + setPageTitle="true"> @@ -32,17 +33,20 @@ - - - - - - - + + + + + + + + + +
- All Logs -
- {{search.name}} -
Saved Searches
+ +
+ +
@@ -52,18 +56,19 @@ Total Unique Message types: {{ vm.commonLogMessages.length }} - - - - - - - -
- {{ template.MessageTemplate }} - - {{ template.Count }} -
+ + + + + + + + +
Common Log Messages Total Unique Message types: {{ vm.commonLogMessages.length }}
+ {{ template.MessageTemplate }} + + {{ template.Count }} +
- + {{ vm.numberOfErrors }} - - + + {{ vm.logLevel }} - +
@@ -118,8 +123,8 @@
- - + + diff --git a/src/Umbraco.Web.UI.Client/src/views/logviewer/search.controller.js b/src/Umbraco.Web.UI.Client/src/views/logviewer/search.controller.js index a289a1b35324..b11445e3e48c 100644 --- a/src/Umbraco.Web.UI.Client/src/views/logviewer/search.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/logviewer/search.controller.js @@ -138,11 +138,12 @@ "name": "Find all logs that use a specific log message template", "query": "@MessageTemplate = '[Timing {TimingId}] {EndMessage} ({TimingDuration}ms)'" } - ] + ]; }); //Get all logs on init load getLogs(); + } diff --git a/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html b/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html index ed8c4b3213aa..aad61b739598 100644 --- a/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html +++ b/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html @@ -2,14 +2,14 @@ - + @@ -38,12 +38,7 @@
- - - + @@ -104,143 +99,144 @@
- - + + - - - Sorry, we can not find what you are looking for. - + + + Sorry, we can not find what you are looking for. + - - - + + + -
- Total Items: {{ vm.logItems.totalItems }} -
+
+

Total Items: {{ vm.logItems.totalItems }}

+
+ + + + + + + + + + + + + + + + + + + + + + + + +
Logs Total Items: {{ vm.logItems.totalItems }}
+ Timestamp +   + LevelMachineMessage
{{ log.Timestamp | date:'medium' }}{{ log.Level }}{{ log.Properties.MachineName.Value }}{{ log.RenderedMessage }}
+
+

Exception

+

{{log.Exception}}

+
- - - - - - - - - - - - - - - - - - - - - - -
- Timestamp -   - LevelMachineMessage
{{ log.Timestamp | date:'medium' }}{{ log.Level }}{{ log.Properties.MachineName.Value }}{{ log.RenderedMessage }}
-
-

Exception

-

{{ log.Exception }}

-
- -

Properties

- - - - - - - - - - - - - - - -
Timestamp{{log.Timestamp}}
@MessageTemplate{{log.MessageTemplateText}}
{{key}} - {{val.Value}} - {{val.Value}} - {{val.Value}} - {{val.Value}} - {{val.Value}} -
- -
- - - - - - Search With Google - - - - - - Search With Bing - - - - - - Search Our Umbraco - - - - - - Search Our Umbraco with Google - - - - - - Search Umbraco Source - - - - - - Search Umbraco Issues - - - - -
- -
- - -
- - -
+ + Search + + + + + + + Search With Google + + + + + + Search With Bing + + + + + + Search Our Umbraco + + + + + + Search Our Umbraco with Google + + + + + + Search Umbraco Source + + + + + + Search Umbraco Issues + + + + + + +
+ + +
+ + +
-
-
+
+